From: Will Deacon <will.deacon@arm.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
catalin.marinas@arm.com, akpm@linux-foundation.org,
hanjun.guo@linaro.org, xieyisheng1@huawei.com,
rrichter@cavium.com, james.morse@arm.com
Subject: Re: [PATCH 2/2] arm64: mm: enable CONFIG_HOLES_IN_ZONE for NUMA
Date: Wed, 4 Jan 2017 13:28:31 +0000 [thread overview]
Message-ID: <20170104132831.GD18193@arm.com> (raw)
In-Reply-To: <1481706707-6211-3-git-send-email-ard.biesheuvel@linaro.org>
On Wed, Dec 14, 2016 at 09:11:47AM +0000, Ard Biesheuvel wrote:
> The NUMA code may get confused by the presence of NOMAP regions within
> zones, resulting in spurious BUG() checks where the node id deviates
> from the containing zone's node id.
>
> Since the kernel has no business reasoning about node ids of pages it
> does not own in the first place, enable CONFIG_HOLES_IN_ZONE to ensure
> that such pages are disregarded.
>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> arch/arm64/Kconfig | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 111742126897..0472afe64d55 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -614,6 +614,10 @@ config NEED_PER_CPU_EMBED_FIRST_CHUNK
> def_bool y
> depends on NUMA
>
> +config HOLES_IN_ZONE
> + def_bool y
> + depends on NUMA
> +
> source kernel/Kconfig.preempt
> source kernel/Kconfig.hz
I'm happy to apply this, but I'll hold off until the first patch is queued
somewhere, since this doesn't help without the VM_BUG_ON being moved.
Alternatively, I can queue both if somebody from the mm camp acks the
first patch.
Will
next prev parent reply other threads:[~2017-01-04 13:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-14 9:11 [PATCH 0/2] arm64: numa: fix spurious BUG() on NOMAP regions Ard Biesheuvel
2016-12-14 9:11 ` [PATCH 1/2] mm: don't dereference struct page fields of invalid pages Ard Biesheuvel
2017-01-04 12:16 ` Will Deacon
2016-12-14 9:11 ` [PATCH 2/2] arm64: mm: enable CONFIG_HOLES_IN_ZONE for NUMA Ard Biesheuvel
2016-12-15 15:39 ` Robert Richter
2016-12-15 16:07 ` Ard Biesheuvel
2016-12-16 17:10 ` Robert Richter
2016-12-16 1:57 ` Hanjun Guo
2016-12-16 17:14 ` Robert Richter
2017-01-04 13:28 ` Will Deacon [this message]
2017-01-04 13:50 ` Ard Biesheuvel
2017-01-04 14:02 ` Will Deacon
2017-01-05 11:24 ` Robert Richter
2017-01-05 12:08 ` Will Deacon
2017-01-05 12:22 ` Robert Richter
2017-01-05 19:49 ` Robert Richter
2017-01-06 12:03 ` Will Deacon
2017-01-06 12:22 ` Ard Biesheuvel
2017-02-06 13:36 ` Robert Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170104132831.GD18193@arm.com \
--to=will.deacon@arm.com \
--cc=akpm@linux-foundation.org \
--cc=ard.biesheuvel@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=hanjun.guo@linaro.org \
--cc=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rrichter@cavium.com \
--cc=xieyisheng1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).