From: Nathan Sullivan <nathan.sullivan@ni.com>
To: Ralf Baechle <ralf@linux-mips.org>, <linux-mips@linux-mips.org>
Cc: <davem@davemloft.net>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] MIPS: NI 169445 board support
Date: Wed, 4 Jan 2017 10:38:36 -0600 [thread overview]
Message-ID: <20170104163836.GA18069@nathan3500-linux-VM> (raw)
In-Reply-To: <20161220163434.GA15962@linux-mips.org>
On Tue, Dec 20, 2016 at 05:34:34PM +0100, Ralf Baechle wrote:
> On Fri, Dec 02, 2016 at 09:42:09AM -0600, Nathan Sullivan wrote:
> > Date: Fri, 2 Dec 2016 09:42:09 -0600
> > From: Nathan Sullivan <nathan.sullivan@ni.com>
> > To: ralf@linux-mips.org, mark.rutland@arm.com, robh+dt@kernel.org
> > CC: linux-mips@linux-mips.org, devicetree@vger.kernel.org,
> > linux-kernel@vger.kernel.org, Nathan Sullivan <nathan.sullivan@ni.com>
> > Subject: [PATCH] MIPS: NI 169445 board support
> > Content-Type: text/plain
> >
> > Support the National Instruments 169445 board.
>
> Nathan,
>
> I assume you're going to repost the changes Rob asked for in
> https://patchwork.linux-mips.org/patch/14641/#26924 and resubmit?
>
> Thanks,
>
> Ralf
Hmm, I found the issue with the generic MIPS config and dwc_eth_qos. The NIC
driver attempts to cache align a descriptor ring using the ___cacheline_aligned
attribute on the descriptor struct, in combination with a "skip" feature in
hardware. However, the skip feature only has a three bit field, and the generic
MIPS config selects MIPS_L1_CACHE_SHIFT_7. So, the line size is 128, and with a
64-bit bus, that means the NIC descriptor skip field would need to be set to
14 to align the 16-byte descriptors...
I guess it makes sense for a generic MIPS kernel to align everything for 128 byte
cache lines, and for me to fix the dwc_eth_qos driver to handle cases where the
line size is too big for the hardware skip feature, right?
Thanks,
Nathan
next prev parent reply other threads:[~2017-01-04 16:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-02 15:42 [PATCH] MIPS: NI 169445 board support Nathan Sullivan
2016-12-02 16:21 ` Zubair Lutfullah Kakakhel
2016-12-02 17:30 ` Nathan Sullivan
2016-12-09 21:18 ` Rob Herring
2016-12-14 16:32 ` Nathan Sullivan
2016-12-14 16:48 ` Rob Herring
2016-12-13 18:40 ` Paul Burton
2016-12-13 18:56 ` Nathan Sullivan
[not found] ` <20161220163434.GA15962@linux-mips.org>
2017-01-04 16:38 ` Nathan Sullivan [this message]
2017-01-05 18:28 ` Niklas Cassel
2017-01-05 18:33 ` Joao Pinto
2017-01-05 18:44 ` Nathan Sullivan
2017-01-05 18:45 ` Joao Pinto
2017-07-14 17:16 RESEND PATCH v5 Nathan Sullivan
2017-07-14 17:16 ` [PATCH] MIPS: NI 169445 board support Nathan Sullivan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170104163836.GA18069@nathan3500-linux-VM \
--to=nathan.sullivan@ni.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).