From: Will Deacon <will.deacon@arm.com>
To: Andy Gross <andy.gross@linaro.org>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, lorenzo.pieralisi@arm.com,
Kevin Hilman <khilman@baylibre.com>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux@armlinux.org.uk
Subject: Re: [Patch v2 1/2] arm: kernel: Add SMC structure parameter
Date: Wed, 4 Jan 2017 17:33:52 +0000 [thread overview]
Message-ID: <20170104173352.GO18193@arm.com> (raw)
In-Reply-To: <1483054046-3327-2-git-send-email-andy.gross@linaro.org>
On Thu, Dec 29, 2016 at 05:27:25PM -0600, Andy Gross wrote:
> This patch adds a quirk parameter to the arm_smccc_smc call. The quirk
> structure allows for specialized SMC operations due to SoC specific
> requirements. The current arm_smccc_smc is renamed and macros are used
> instead to specify the standard arm_smccc_smc or the arm_smccc_smc_quirk
> function.
>
> This patch and partial implementation was suggested by Will Deacon.
>
> Signed-off-by: Andy Gross <andy.gross@linaro.org>
> ---
> arch/arm/kernel/armksyms.c | 2 +-
> arch/arm/kernel/smccc-call.S | 7 ++++---
> arch/arm64/kernel/arm64ksyms.c | 2 +-
> arch/arm64/kernel/asm-offsets.c | 7 +++++--
> arch/arm64/kernel/smccc-call.S | 7 ++++---
> include/linux/arm-smccc.h | 28 ++++++++++++++++++++++++----
> 6 files changed, 39 insertions(+), 14 deletions(-)
[...]
> @@ -101,4 +115,10 @@ asmlinkage void arm_smccc_hvc(unsigned long a0, unsigned long a1,
> unsigned long a5, unsigned long a6, unsigned long a7,
> struct arm_smccc_res *res);
>
> +#define arm_smccc_smc(a0, a1, a2, a3, a4, a5, a6, a7, res) \
> + __arm_smccc_smc(a0, a1, a2, a3, a4, a5, a6, a7, res, NULL)
> +
> +#define arm_smccc_smc_quirk(a0, a1, a2, a3, a4, a5, a6, a7, res, quirk) \
> + __arm_smccc_smc(a0, a1, a2, a3, a4, a5, a6, a7, res, quirk)
This might be a bit cleaner with a variadic macro, but either way:
Reviewed-by: Will Deacon <will.deacon@arm.com>
Will
next prev parent reply other threads:[~2017-01-04 17:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-29 23:27 [Patch v2 0/2] Support ARM SMCC SoC vendor quirks Andy Gross
2016-12-29 23:27 ` [Patch v2 1/2] arm: kernel: Add SMC structure parameter Andy Gross
2017-01-04 17:33 ` Will Deacon [this message]
2016-12-29 23:27 ` [Patch v2 2/2] firmware: qcom: scm: Fix interrupted SCM calls Andy Gross
2017-01-04 17:33 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170104173352.GO18193@arm.com \
--to=will.deacon@arm.com \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=khilman@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lorenzo.pieralisi@arm.com \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).