From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S969946AbdAEBBV (ORCPT <rfc822;w@1wt.eu>);
        Wed, 4 Jan 2017 20:01:21 -0500
Received: from mail-pf0-f195.google.com ([209.85.192.195]:35645 "EHLO
        mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S965979AbdAEBBL (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 4 Jan 2017 20:01:11 -0500
Date: Thu, 5 Jan 2017 10:01:21 +0900
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Petr Mladek <pmladek@suse.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Jan Kara <jack@suse.cz>, Tejun Heo <tj@kernel.org>,
        Calvin Owens <calvinowens@fb.com>,
        Steven Rostedt <rostedt@goodmis.org>, Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Andy Lutomirski <luto@kernel.org>,
        Peter Hurley <peter@hurleysoftware.com>, linux-kernel@vger.kernel.org,
        Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Subject: Re: [PATCHv7 5/8] printk: report lost messages in printk safe/nmi
 contexts
Message-ID: <20170105010121.GB480@jagdpanzerIV.localdomain>
References: <20161227141611.940-1-sergey.senozhatsky@gmail.com>
 <20161227141611.940-6-sergey.senozhatsky@gmail.com>
 <20170104144608.GS14894@pathway.suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170104144608.GS14894@pathway.suse.cz>
User-Agent: Mutt/1.7.2 (2016-11-26)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On (01/04/17 15:46), Petr Mladek wrote:
> On Tue 2016-12-27 23:16:08, Sergey Senozhatsky wrote:
> > Account lost messages in pritk-safe and printk-safe-nmi
> > contexts and report those numbers during printk_safe_flush().
> > 
> > The patch also moves lost message counter to struct
> > `printk_safe_seq_buf' instead of having dedicated static
> > counters - this simplifies the code.
> > 
> > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> 
> I like that the handling is localized in printk_safe.c and that
> the warning is printed right after the messages that fit the buffer.
> 
> Reviewed-by: Petr Mladek <pmladek@suse.com>

thanks.

	-ss