From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758540AbdAEGsd (ORCPT ); Thu, 5 Jan 2017 01:48:33 -0500 Received: from mail.kernel.org ([198.145.29.136]:56934 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755251AbdAEGrK (ORCPT ); Thu, 5 Jan 2017 01:47:10 -0500 Date: Thu, 5 Jan 2017 14:46:53 +0800 From: Shawn Guo To: Baoyou Xie Cc: jun.nie@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com, krzk@kernel.org, arnd@arndb.de, ulf.hansson@linaro.org, amitdanielk@gmail.com, claudiu.manoil@nxp.com, yangbo.lu@nxp.com, pankaj.dubey@samsung.com, geert+renesas@glider.be, laurent.pinchart@ideasonboard.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, xie.baoyou@zte.com.cn, chen.chaokai@zte.com.cn, wang.qiang01@zte.com.cn Subject: Re: [PATCH v6 1/5] dt-bindings: zte: documents zx2967 power domain driver bindings Message-ID: <20170105064651.GA4667@x250> References: <1483530494-14177-1-git-send-email-baoyou.xie@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1483530494-14177-1-git-send-email-baoyou.xie@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 04, 2017 at 07:48:10PM +0800, Baoyou Xie wrote: > This patch documents devicetree tree bindings for the ZTE zx2967 'devicetree' is good enough, and the 'tree' after it is redundant. > power domain driver. DT bindings is to describe hardware block not software, so the word like 'driver' is not appropriate. So please drop it from here and the patch subject. > > Signed-off-by: Baoyou Xie > --- > Documentation/devicetree/bindings/soc/zte/pd-2967xx.txt | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/zte/pd-2967xx.txt > > diff --git a/Documentation/devicetree/bindings/soc/zte/pd-2967xx.txt b/Documentation/devicetree/bindings/soc/zte/pd-2967xx.txt > new file mode 100644 > index 0000000..1476318 > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/zte/pd-2967xx.txt > @@ -0,0 +1,17 @@ > +* ZTE 2967 SoC Power Domains ZTE ZX2967 family. And this is a bindings document for PCU, IMO. And do we know the full name of abbreviation 'PCU'? Power Control Unit? > + > +2967 processors include support for multiple power domains which are used ZX2967 family > +to gate power to one or more peripherals on the processor. > + > +Required Properties: > +- compatible: should be one of the following. > + * zte,zx296718-pcu - for zx296718 board's power domain. Drop 'board's'. > +- reg: physical base address of the controller and length of memory mapped > + region. > + > +Example: > + > + pcu_domain: pcu@0x00117000 { The unit-address in node name shouldn't have 0x and leading zeros. pcu_domain: pcu@117000 { Shawn > + compatible = "zte,zx296718-pcu"; > + reg = <0x00117000 0x1000>; > + }; > -- > 2.7.4 >