From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S968487AbdAEIDT (ORCPT ); Thu, 5 Jan 2017 03:03:19 -0500 Received: from mail-wj0-f179.google.com ([209.85.210.179]:35831 "EHLO mail-wj0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S968428AbdAEIDR (ORCPT ); Thu, 5 Jan 2017 03:03:17 -0500 Date: Thu, 5 Jan 2017 08:07:01 +0000 From: Lee Jones To: Charles Keepax Cc: patches@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] mfd: arizona: Use regmap_read_poll_timeout instead of hard coding it Message-ID: <20170105080701.GJ24225@dell> References: <1483542655-19980-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> <1483542655-19980-3-git-send-email-ckeepax@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1483542655-19980-3-git-send-email-ckeepax@opensource.wolfsonmicro.com> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 04 Jan 2017, Charles Keepax wrote: > arizona_poll_reg essentially hard-codes regmap_read_poll_timeout, this > patch updates the implementation to use regmap_read_poll_timeout. We > still keep arizona_poll_reg around as regmap_read_poll_timeout is a > macro so rather than expand this for each caller keep it wrapped in > arizona_poll_reg. > > Signed-off-by: Charles Keepax > --- > drivers/mfd/arizona-core.c | 28 +++++++++++----------------- > 1 file changed, 11 insertions(+), 17 deletions(-) > > diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c > index 4cb34c3..e6fae3c 100644 > --- a/drivers/mfd/arizona-core.c > +++ b/drivers/mfd/arizona-core.c > @@ -236,28 +236,22 @@ static irqreturn_t arizona_overclocked(int irq, void *data) > } > > static int arizona_poll_reg(struct arizona *arizona, > - int timeout, unsigned int reg, > + int npolls, unsigned int reg, > unsigned int mask, unsigned int target) > { > + const int poll_us = 7500; Get rid of this and replace its usage with a nice #define describing exactly what the timeout is for i.e what timed out. ... okay, I just read the doc. This should really be 'SLEEP'. Where did 7500 come from anyway? Is it documented? > unsigned int val = 0; > - int ret, i; > - > - for (i = 0; i < timeout; i++) { > - ret = regmap_read(arizona->regmap, reg, &val); > - if (ret != 0) { > - dev_err(arizona->dev, "Failed to read reg 0x%x: %d\n", > - reg, ret); > - continue; > - } > - > - if ((val & mask) == target) > - return 0; > + int ret; > > - usleep_range(1000, 5000); > - } > + ret = regmap_read_poll_timeout(arizona->regmap, > + ARIZONA_INTERRUPT_RAW_STATUS_5, val, > + ((val & mask) == target), poll_us, > + npolls * poll_us); What's the relevance of npolls? Is this number documented, or was it pulled from your ... err, the air? > + if (ret) > + dev_err(arizona->dev, "Polling reg 0x%x timed out: %x\n", > + reg, val); > > - dev_err(arizona->dev, "Polling reg 0x%x timed out: %x\n", reg, val); > - return -ETIMEDOUT; > + return ret; > } > > static int arizona_wait_for_boot(struct arizona *arizona) -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog