From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1033076AbdAEIRc (ORCPT ); Thu, 5 Jan 2017 03:17:32 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:33366 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933879AbdAEIPt (ORCPT ); Thu, 5 Jan 2017 03:15:49 -0500 Date: Thu, 5 Jan 2017 09:15:34 +0100 From: Ingo Molnar To: Dou Liyang Cc: linux-kernel@vger.kernel.org, x86@kernel.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com Subject: Re: [PATCH] x86/apic: Fix two typos in comments Message-ID: <20170105081534.GE2098@gmail.com> References: <1482732316-3908-1-git-send-email-douly.fnst@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1482732316-3908-1-git-send-email-douly.fnst@cn.fujitsu.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Dou Liyang wrote: > s/inr_logical_cpuidi/nr_logical_cpuids/ > s/generic_processor_info()/__generic_processor_info()/ > > Signed-off-by: Dou Liyang > --- > arch/x86/kernel/apic/apic.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c > index 5b7e43e..c32a3ad 100644 > --- a/arch/x86/kernel/apic/apic.c > +++ b/arch/x86/kernel/apic/apic.c > @@ -2028,7 +2028,7 @@ void disconnect_bsp_APIC(int virt_wire_setup) > /* > * The number of allocated logical CPU IDs. Since logical CPU IDs are allocated > * contiguously, it equals to current allocated max logical CPU ID plus 1. > - * All allocated CPU ID should be in [0, nr_logical_cpuidi), so the maximum of > + * All allocated CPU ID should be in [0, nr_logical_cpuids), so the maximum of There's another typo in that sentence as well, and the wording should be clarified as well while at it. Something like this would work for me: > + * All allocated CPU IDs should be in the [0, nr_logical_cpuids) range, > + * so the maximum of Thanks, Ingo