From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161420AbdAELYh (ORCPT ); Thu, 5 Jan 2017 06:24:37 -0500 Received: from mail-sn1nam01on0045.outbound.protection.outlook.com ([104.47.32.45]:53734 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1033644AbdAELYW (ORCPT ); Thu, 5 Jan 2017 06:24:22 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Robert.Richter@cavium.com; Date: Thu, 5 Jan 2017 12:24:07 +0100 From: Robert Richter To: Will Deacon CC: Ard Biesheuvel , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , Catalin Marinas , Andrew Morton , Hanjun Guo , Yisheng Xie , James Morse Subject: Re: [PATCH 2/2] arm64: mm: enable CONFIG_HOLES_IN_ZONE for NUMA Message-ID: <20170105112407.GU4930@rric.localdomain> References: <1481706707-6211-1-git-send-email-ard.biesheuvel@linaro.org> <1481706707-6211-3-git-send-email-ard.biesheuvel@linaro.org> <20170104132831.GD18193@arm.com> <20170104140223.GF18193@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20170104140223.GF18193@arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [92.224.59.222] X-ClientProxiedBy: AM5PR0101CA0011.eurprd01.prod.exchangelabs.com (10.169.240.21) To CY1PR07MB2346.namprd07.prod.outlook.com (10.166.194.145) X-MS-Office365-Filtering-Correlation-Id: bdb11342-ddc2-4aa1-9c3f-08d4355d6445 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:CY1PR07MB2346; X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2346;3:7bmedtr+Od5txt/UVTo8KCN9Px7+Hp4NZ+tDE21XqwHQmgIkmrdDEJiY5Yw0TbpPcEsImjF8p+XVI2nIEIWyb88XUBvxMl4Zla5FIdamJfRMEfxEmyMwNurfSoPIBZtDBWrWqrRESEg3deAj4/VtrkHliveVuGe2Ds95FuK7yRsSxNyqhNlqJHIrwY/3ArbKittjoDMImrJxyjZJU4bw7E+MYfAmbnpluPydLucYgfAuK0PEXbyAafzKWrns9RBwQmqgpj5MkdD+e8IPdgan3Q== X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2346;25:XY7rQlqEgWX6wCZLqOzHcrW6YeOO066Y94yceX731c2BR3viKJUudFpyJObc84DrnsskvLTePAc6EpU7l1HKanfAvU2u1IBCP6+2H4gSLXHpJiuNynTQVusecOypAJqGuJtlzi6/qibG8zy8CxBmlbiAhApTnncEqIYSLVLeuGDoxnKFyreXLkk0bpanWtNRyZwndjgSFSnQ92wlnH/bzCxfPC3MLuCvIr7Xsljb4OzaHUBaf3CL781KDP1761DtJzUjc29MthsIIsIBHJiTzgZxlHZ80Zj2HgpRDpQ10cNlkPruk5d8mq2UdeAZKIhPvbd0ViCoY9e4PRNu0c8eVUbDazEq8DTJXrra0MRGp4MNkx+txSipqhqpBkzjAKhqd9VujXXF71GWK7yki9ILCzEyOEu3vpbQF9pJQ9cGchTuya/yowoo/5yyQYEPV4oKCMWamCuSsOjjBt6MiysCn0uJVqoZW01/qq4ubd4Ct7HEbL61+Wh8f38zYswKYel8Ug7jk26Be1df6wj4xJVT/fJit6PUWr9/SKtFzPq4ftedr3VPxqVNwOFmdZV9GdJoMNNiiUq32tT15VtaZf8cNC6OWBOwiK3xP7OV3x9pKe41prCek4CwXjuIgOCBismobGKy69U7h2+5dAzWmS6Jo1x09cA2xlaRHG3ioIOXfE6uPgHFG7SCgx97prg6UIodQKKufReWykU+W/siAC7uGJ4NsMes2572gnXdoccvdCOKrg/mdzYo9NJkOBViNHKR X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2346;31:N7pJ5EIqpDRxbOEzvxRxpCrJV8hq/hp+AnFrFE06mpRIBU8OEUsnVuNHZf8p2yQBeCDxb/vNvMea41NTxoMdqijb1AXc0p0Cm0/gFkVL+b58dQZK+P2zOEnBHp2gkVB7wgTN8zZ8Ap/IYkqWJ3ZWdDXfOStV7fw791BFqDpOYaHb2rv6wgjZCbhKUxCqIbzv5+u9KZCE5p0VlxHLCWyX9HCTzZpN5cTeJECOzNY2Kc/kUXMfSSFl2htZg9LE/1M8DtCDMfq4Wrh4y5NkrAu48w==;20:DVOgvEwpqCSFvLp7AXn0RTIdD7xx3XYst9iVfqRflgSAoK2Nyp794HCfQcsrmR+NevQmYmgBIv0RVbhw15Ub6JhnLReknPV8YdksJW9qL3UHfDaXqC7z/8uq2TaU0vlUe/AAkOYGwBoXvQjus6KRn+6y7++KzZ+puqAsIoXRpU8bIhFwqs2wOTn07AB8kW+1zf6aZotsC5gAHKIG2Vh1rRMXX7Y1tHOOfKo/NzFefi9iUlwPvsbudbRso1my3Hv6xLRWN1RYzzSHF0gtbwtRV3zP1mQdb+0EL97SLDiX+E68GnJM/OwnP7cq4DJafcgtZdsjNlzZ2VS+HpJhbCLTJy8Yx+jqy1mDhUbm4YilWuoCO9/56Yy5diJmELLP4fggNn4JIeuYW2hwOMBiZph3t86cpkkMLPhVvprTSVhQuw76YSlxWcK7C3y5t1Pu9z0rkMxOGprFQzlg38OsxiEXj+2vePZdMl21H2HcRJ3NxN8Auo+p3G59axxltt1+Zs62 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6041248)(20161123555025)(20161123564025)(20161123560025)(20161123558021)(20161123562025)(6072148)(6042181);SRVR:CY1PR07MB2346;BCL:0;PCL:0;RULEID:;SRVR:CY1PR07MB2346; X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2346;4:CX2cnsR8xyyUCT/pdj+kKc9V/hqB/A5Nb65SFNX6pk9rQw1Z5v27CEaLXCJVjUNbocYHc2Az661YUE1UA7eu6GtpDV78zGQiSME1I+FwruvUMFK/TZUPKSF0A0Av9IvqxYAPtEp3GFPVcAUE+idx7CaCDEtrA83Dmx2R9oGpAJAJFZPC7O+gwXTbAYnHv+B6awyFR06U6K7AwsVo22GgPbSD2f3MsDP7ECOHDcGR5nK5uEN0cfO2Oe+gHxCgtnYxWuN71QLgFZd/u2+0n5gGaKX4+EQVTexmujFN8muHkc4i22mr1FfF2VTY+ar9anwunuNMJiia6AQ1LKy/UKdc8h/T92yg2pOG1x4QXbAX/E6Expw8JG2lMBkmaJfuabsQ1WLTU+5bjSoIz95+Audqci2vm7/9227Qx0x9C+Pu6pQcLLKpht7S4nbeZHRtQ7JXJl3rBgpgBk1cngxtDV98uF/iwJHydQ0pQrOmYryAi3mslgK+uJz0s2CE+ItP08VYaiR8aWmP9GKNAy/oV/Njps485Z1GRlRDkWPsKSiYq5P2roeDJSQm8mmnEM+aLFA8CgZKJtvZWQyhiz03yxU2W22isn48+F6XRwK763KwZerssXTepn6cJYuvAW5ZlyBi X-Forefront-PRVS: 0178184651 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(189002)(24454002)(199003)(86362001)(25786008)(92566002)(6116002)(23726003)(6506006)(42186005)(7416002)(3846002)(38730400001)(46406003)(9686002)(33656002)(81156014)(8676002)(106356001)(81166006)(1076002)(7736002)(97756001)(105586002)(4326007)(97736004)(93886004)(305945005)(54906002)(4001350100001)(68736007)(55016002)(101416001)(110136003)(5660300001)(229853002)(50466002)(6916009)(50986999)(66066001)(47776003)(54356999)(2906002)(6666003)(83506001)(2950100002)(189998001)(76176999)(18370500001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR07MB2346;H:rric.localdomain;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CY1PR07MB2346;23:o9q6wI4o+yazCHkKWhU7HTr+7E3pbRz6lJ+gStj1p?= =?us-ascii?Q?OFqFLCNFn/6fW8Wo9Gl44b5fAsOAk3G0k0QaogEb9G/SOwsYclMw7aj41t1n?= =?us-ascii?Q?c0tikYUK/izcIDnS+F+C8/ieO1P+eFPQnP4lJpJpPYTpmyhj6p9s/8KKOjf5?= =?us-ascii?Q?eQP5qfcRyBdfdOusc/NGo3FLD0vh5/TiXc9NLdzt35gBx/MyTY4auqFJr5GX?= =?us-ascii?Q?AVx50L2rc9+uxhGzsFe0emQH/N1Yr71Pex+4sziF6romrmR78vaao6ezD2ub?= =?us-ascii?Q?obr4sNLUqrr7FAMvW6mK3cSZMpLeCYXwIC4iXzKFolswrD6+6uQs4eajzAbG?= =?us-ascii?Q?qi1QdpCCBjOTV2Xcy3jmqwxVskXHYwn0b3Hy0kMv/lasX1H2Dku3y7cLVifU?= =?us-ascii?Q?9R+h7w29JW/CZ/HPiHASGMMUtzrZMUXMlsJ40TkaXM9r3SsQMoeVjt/Sey6X?= =?us-ascii?Q?zqEPfLJ2ePkltyfshvuhnlfXUN6aAraoTmlhtBSAOJ7CJKC98/NiooUTWimI?= =?us-ascii?Q?mGLSHb34KhBjPmnA+gVSz/w+qkpgrpcLtRFEU3qn+qgeDlqcDFBrS2y92hj2?= =?us-ascii?Q?FxyHpQWPI5Y5TQDKl6EQaHwz0mNdcM/pP9bi6powKohm7VIsIMS1MtkGfxGx?= =?us-ascii?Q?d6yvOOQfZ94C0pcsjbVPUwozTR7XZlTjUD8sP1KML8zdJ5Q7ekQ12yXWAcOu?= =?us-ascii?Q?syJuUcP3tNAaTK3+Y70ssHNJ1/cpVaRzCOwMGd9jk/TXeOIqnLWhcKjtsUro?= =?us-ascii?Q?YI2AM2Z67SYAEZJJmVuGILoieARNcwFbnV3LuzFZEbrxhWCJb8d8vZlbEQBa?= =?us-ascii?Q?QKmGQkoUl+wHunEGLBF833lXvI0Gr6lAlYNbibQ9GxzjWAsa3qdLDMEeRSbG?= =?us-ascii?Q?mpJoddyV1m7LK6WS52D6iNJRm9IDSu3E53gvdocNNCflW7nNCPODT7yikA5D?= =?us-ascii?Q?D6Bvt+CLrhDJRol+r278uscEusJZTE4Ccia2YfzNaAwS4qdKEZdweGFkNP6U?= =?us-ascii?Q?knMPh2Nhn5cw9oLQnsE0JRPRmPu4qefn+4jKTKNpx0dF72DxkGOrqdXK/tee?= =?us-ascii?Q?TLEmEE8ZM4FdCxCWlfNW0qkBAITgb/iASeCORow9q+G/kCfeSHordd3nNxfr?= =?us-ascii?Q?LxlpqBQ1opTwT4WAR3NM2ayEivhKXAnsUFxhzvBGSwV83EQ4csqTsZrAPUN3?= =?us-ascii?Q?v4wOVFG1fPEGWYDzeiO8/v92adwH6hFe6MQJ9NtZJJg/MGNEnZFJhvE5oBsp?= =?us-ascii?Q?lPUe7DzBBMMR0R89Vo=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2346;6:g4zKZpWR6Xp2cXsvIx2NjFC7mY2liNJ6U0zMnxw4HsQiDJy4timgjn5ZSU6qqcQzjBhO+nBJW7hfJzITk++yWr2QR4XVdenBCbhlK1S1zfCq4Wu/kFU6+TirizcvKGh4loQF1P4ucZ+F+/bNPnZGpYUn4xOsKVqoMtwpbDLUMFQPK+P0E4zS5D7snhCOq78GOpxeNiPNKqydx+dFkQ9Tf69oOCOlEAyN+G7nVlMH9h4p+/bKI7Qcxx4NP5wg2WbhDKdhvt0xpW7iVb386HSnZZU75yuB1Erou1b9/Jcn7V1bfwQoZOajbjWKdpmoZfGyLmQtVCUYzghA2KORNfl3W6hzFEC7lacC1mqLfFgFcp4EQ4Pen/gb635vMWVoKr7tbTtn1SycK9vvHe6OVvV/I5MBqXJoX7XU45NkeIuiWWQ=;5:ePyolamlPLoHMayqKeRmYnfCAuJjayHgGYAifz0rwIWh/lCoDjxWXyYMvXQWaPRum/PkLAYdFx2IXeWH16eREQlsmhFv1+0r4B31GdBpxHs6AzU5UAuU7NDF714lC640L2V+Oog9bPcLw2VU6iGfdvcHkFGnzYrp2AvxSeMLIy4=;24:xxl8u98ieSoqgruARkGncAFXerFZ3m4oNMZiI69FsVNyAirnQFCugZHDkmziku//mndC19TwZ4g+ujEmzajYzRPgdh+ZsTxdLxL0i24YjW0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2346;7:EFqaftReuaUV+gviTBwYUd1fbSAdQcnFf3Os1ZY6AQtYy/QSC/9YC01DIg5QCKuOMgYpcK17VuoB1CDAmylN+zJxtu/0VCfiwODNatXFhD5W9ydIRdqzY90Inal7PZF8C0pzFLK2bWZdlsBeRiGy8ibyRFlThPFN7LP8UtimmZ8d7apvjrpFZCZ37ZmDecjs/hmjdH7lWhAVTwctEOvhCJrYT2jkd3n5a9X1H9373nz8/SXn8WX9Zc5v/4Nyd4n6uYYUSerr9udqYBSiYLALl3Jvf9Ty5KxVtLqBN5y54U2Mmjh9KSJGcfQQsgrXs6rVaeUQZxpel2Yq2wtMgnrJIP6yHbi8FBhdxdC9+7ZhDcGt/pLdapPdNvonq7FmxkD/oDhSTcNxfCFr+605kawC50FvjbxN6GCfL45hpve9Xr46SGwJ1gspAXZRIE5aPUXr5Vv6Q0MsrTTNixIG1O3evg== X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2017 11:24:17.6270 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB2346 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04.01.17 14:02:23, Will Deacon wrote: > Using early_pfn_valid feels like a bodge to me, since having pfn_valid > return false for something that early_pfn_valid says is valid (and is > therefore initialised in the memmap) makes the NOMAP semantics even more > confusing. The concern I have had with HOLES_IN_ZONE is that it enables pfn_valid_within() for arm64. This means that each pfn of a section is checked which is done only once for the section otherwise. With up to 2^18 pages per section we traverse the memblock list by that factor more often. There could be a performance regression. I haven't numbers yet, since the fix causes another kernel crash. And, this is the next problem I have. The crash doesn't happen otherwise. So, either it uncovers another bug or the fix is incomplete. Though the changes look like it should work. This needs more investigation. -Robert