* linux-next: build warning after merge of the battery tree
@ 2017-01-05 1:53 Stephen Rothwell
2017-01-05 23:29 ` Sebastian Reichel
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2017-01-05 1:53 UTC (permalink / raw)
To: Sebastian Reichel; +Cc: linux-next, linux-kernel, Quentin Schulz
Hi all,
After merging the battery tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
drivers/power/supply/axp20x_usb_power.c: In function 'axp20x_usb_power_probe':
drivers/power/supply/axp20x_usb_power.c:297:21: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
power->axp20x_id = (int)of_device_get_match_data(&pdev->dev);
^
Introduced by commit
0dcc70ca8644 ("power: supply: axp20x_usb_power: use of_device_id data field instead of device_is_compatible")
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: build warning after merge of the battery tree
2017-01-05 1:53 linux-next: build warning after merge of the battery tree Stephen Rothwell
@ 2017-01-05 23:29 ` Sebastian Reichel
0 siblings, 0 replies; 6+ messages in thread
From: Sebastian Reichel @ 2017-01-05 23:29 UTC (permalink / raw)
To: Quentin Schulz; +Cc: linux-next, linux-kernel, Stephen Rothwell
[-- Attachment #1: Type: text/plain, Size: 560 bytes --]
Hi Quentin,
On Thu, Jan 05, 2017 at 12:53:42PM +1100, Stephen Rothwell wrote:
> After merging the battery tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> drivers/power/supply/axp20x_usb_power.c: In function 'axp20x_usb_power_probe':
> drivers/power/supply/axp20x_usb_power.c:297:21: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
> power->axp20x_id = (int)of_device_get_match_data(&pdev->dev);
Can you send a follow-up patch fixing this false-positive warning?
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: build warning after merge of the battery tree
2014-09-25 4:22 Stephen Rothwell
@ 2014-09-25 7:00 ` Krzysztof Kozlowski
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2014-09-25 7:00 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Sebastian Reichel, linux-next, linux-kernel, Lee Jones
On czw, 2014-09-25 at 14:22 +1000, Stephen Rothwell wrote:
> Hi Sebastian,
>
> After merging the battery tree, today's linux-next build (powerpc
> ppc64_defconfig and x86_64 allmodconfig) produced this warning:
>
> fs/sysfs/Kconfig:1:error: recursive dependency detected!
> fs/sysfs/Kconfig:1: symbol SYSFS is selected by CHARGER_MAX14577
> drivers/power/Kconfig:327: symbol CHARGER_MAX14577 depends on POWER_SUPPLY
> drivers/power/Kconfig:1: symbol POWER_SUPPLY is selected by HID_SONY
> drivers/hid/Kconfig:649: symbol HID_SONY depends on NEW_LEDS
> drivers/leds/Kconfig:8: symbol NEW_LEDS is selected by SENSORS_APPLESMC
> drivers/hwmon/Kconfig:299: symbol SENSORS_APPLESMC depends on HWMON
> drivers/hwmon/Kconfig:5: symbol HWMON is selected by EEEPC_LAPTOP
> drivers/platform/x86/Kconfig:496: symbol EEEPC_LAPTOP depends on HOTPLUG_PCI
> drivers/pci/hotplug/Kconfig:5: symbol HOTPLUG_PCI depends on SYSFS
>
> Caused by commit e30110e9c96f ("charger: max14577: Configure
> battery-dependent settings from DTS and sysfs"). Consider depending on
> SYSFS instead of selecting it ... or maybe making your driver work even
> without it.
I'll send a patch changing to "depends on".
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* linux-next: build warning after merge of the battery tree
@ 2014-09-25 4:22 Stephen Rothwell
2014-09-25 7:00 ` Krzysztof Kozlowski
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2014-09-25 4:22 UTC (permalink / raw)
To: Sebastian Reichel
Cc: linux-next, linux-kernel, Krzysztof Kozlowski, Lee Jones
[-- Attachment #1: Type: text/plain, Size: 1135 bytes --]
Hi Sebastian,
After merging the battery tree, today's linux-next build (powerpc
ppc64_defconfig and x86_64 allmodconfig) produced this warning:
fs/sysfs/Kconfig:1:error: recursive dependency detected!
fs/sysfs/Kconfig:1: symbol SYSFS is selected by CHARGER_MAX14577
drivers/power/Kconfig:327: symbol CHARGER_MAX14577 depends on POWER_SUPPLY
drivers/power/Kconfig:1: symbol POWER_SUPPLY is selected by HID_SONY
drivers/hid/Kconfig:649: symbol HID_SONY depends on NEW_LEDS
drivers/leds/Kconfig:8: symbol NEW_LEDS is selected by SENSORS_APPLESMC
drivers/hwmon/Kconfig:299: symbol SENSORS_APPLESMC depends on HWMON
drivers/hwmon/Kconfig:5: symbol HWMON is selected by EEEPC_LAPTOP
drivers/platform/x86/Kconfig:496: symbol EEEPC_LAPTOP depends on HOTPLUG_PCI
drivers/pci/hotplug/Kconfig:5: symbol HOTPLUG_PCI depends on SYSFS
Caused by commit e30110e9c96f ("charger: max14577: Configure
battery-dependent settings from DTS and sysfs"). Consider depending on
SYSFS instead of selecting it ... or maybe making your driver work even
without it.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: build warning after merge of the battery tree
2012-06-19 4:54 Stephen Rothwell
@ 2012-06-19 5:02 ` Anton Vorontsov
0 siblings, 0 replies; 6+ messages in thread
From: Anton Vorontsov @ 2012-06-19 5:02 UTC (permalink / raw)
To: Stephen Rothwell
Cc: linux-next, linux-kernel, Jenny TC, Jean Delvare, Andrew Morton,
Len Brown
Hi Stephen,
On Tue, Jun 19, 2012 at 02:54:08PM +1000, Stephen Rothwell wrote:
> After merging the battery tree, today's linux-next build (i386 defconfig)
> produced this warning:
>
> drivers/power/power_supply_core.c: In function 'psy_register_thermal':
> drivers/power/power_supply_core.c:204:6: warning: passing argument 1 of 'thermal_zone_device_register' discards 'const' qualifier from pointer target type [enabled by default]
> include/linux/thermal.h:149:29: note: expected 'char *' but argument is of type 'const char *'
>
> Introduced by commit 3be330bf8860 ("power_supply: Register battery as a
> thermal zone").
Yup, at the same time as I merged the thermal zone support for
power supply class, I also fixed the root cause of the warning:
http://lkml.org/lkml/2012/6/18/28
But I guess it will go via -mm tree. Or should/can I take it into
battery-2.6 tree? Added Cc's.
Thanks!
--
Anton Vorontsov
Email: cbouatmailru@gmail.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* linux-next: build warning after merge of the battery tree
@ 2012-06-19 4:54 Stephen Rothwell
2012-06-19 5:02 ` Anton Vorontsov
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2012-06-19 4:54 UTC (permalink / raw)
To: Anton Vorontsov; +Cc: linux-next, linux-kernel, Jenny TC
[-- Attachment #1: Type: text/plain, Size: 625 bytes --]
Hi Anton,
After merging the battery tree, today's linux-next build (i386 defconfig)
produced this warning:
drivers/power/power_supply_core.c: In function 'psy_register_thermal':
drivers/power/power_supply_core.c:204:6: warning: passing argument 1 of 'thermal_zone_device_register' discards 'const' qualifier from pointer target type [enabled by default]
include/linux/thermal.h:149:29: note: expected 'char *' but argument is of type 'const char *'
Introduced by commit 3be330bf8860 ("power_supply: Register battery as a
thermal zone").
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-01-05 23:29 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-05 1:53 linux-next: build warning after merge of the battery tree Stephen Rothwell
2017-01-05 23:29 ` Sebastian Reichel
-- strict thread matches above, loose matches on Subject: below --
2014-09-25 4:22 Stephen Rothwell
2014-09-25 7:00 ` Krzysztof Kozlowski
2012-06-19 4:54 Stephen Rothwell
2012-06-19 5:02 ` Anton Vorontsov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).