From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1162447AbdAFDpE (ORCPT <rfc822;w@1wt.eu>);
        Thu, 5 Jan 2017 22:45:04 -0500
Received: from mailout3.samsung.com ([203.254.224.33]:34102 "EHLO
        mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1162364AbdAFDn4 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 5 Jan 2017 22:43:56 -0500
X-AuditID: b6c32a37-f79116d000000e56-97-586f1272cd26
Date: Fri, 06 Jan 2017 12:43:46 +0900
From: Andi Shyti <andi.shyti@samsung.com>
To: sean.wang@mediatek.com
Cc: mchehab@osg.samsung.com, hdegoede@redhat.com, hkallweit1@gmail.com,
        robh+dt@kernel.org, mark.rutland@arm.com, matthias.bgg@gmail.com,
        hverkuil@xs4all.nl, sean@mess.org, ivo.g.dimitrov.75@gmail.com,
        linux-media@vger.kernel.org, devicetree@vger.kernel.org,
        linux-mediatek@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        keyhaede@gmail.com
Subject: Re: [PATCH 2/2] media: rc: add driver for IR remote receiver on MT7623
 SoC
Message-id: <20170106034346.7njhyhtsc4yado5c@gangnam.samsung>
MIME-version: 1.0
Content-type: text/plain; charset=us-ascii
Content-disposition: inline
In-reply-to: <1483632384-8107-3-git-send-email-sean.wang@mediatek.com>
User-Agent: NeoMutt/20161126 (1.7.1)
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrBJsWRmVeSWpSXmKPExsWy7bCmgW6RUH6Ewdb/Nhbzj5xjtXhzfDqT
        xaL3M1gtTk1+xmSx5MohdoueWx1MFpseX2O1uLxrDptFz4atQFbzRUaLpdcvMlk0tRhbrH5W
        YdG69wi7xZm5G1gtFj79zuIg4LFm3hpGj52z7rJ7bFrVyeaxeUm9R8vJ/SweS95Ye2zpBwq/
        33eVzePzJjmPU18/swdwRaXaZKQmpqQWKaTmJeenZOal2yp5B8c7x5uaGRjqGlpamCsp5CXm
        ptoqufgE6Lpl5gA9oqRQlphTChQKSCwuVtK3synKLy1JVcjILy6xVYo2NDTSMzQw1zMyMtIz
        MY61MjIFKklIzWi5dZCp4B5zRde8JawNjI3MXYycHBICJhJ/1i9kg7DFJC7cWw9kc3EICexg
        lOjv3g1WJCTQziRxYpEjTEPb3s3sEPE5jBLHFlVANHxklLh18TArSIJFQFVi/d3JYFPZBDQl
        mm7/ALNFBKQktnZ9YgJpYBZoZ5aYO2kzWIOwQKhEy5sTLF2MHBy8ArYSew8Jg4R5BQQlfky+
        xwJiMwvoSJw9to4RwpaWePR3BtgRnAJuEhuPtYPZogIqEl2HnrGAzJcQaOWQWDhzB9hMCQFZ
        iU0HmCFMF4nP07khfhGWeHV8CzuELS2x6t8tJgi7XGLtwe1MEGNaGCV+v7wKDSFjifsP7jFD
        3MAn8e5rDyvETF6JjjYhiBIPicunlkLNdJTYMGE5CyR8rjJKbFv3m3UCo/wsJK/NQvLaLCSv
        LWBkXsUollpQnJueWmxYYKxXnJhbXJqXrpecn7uJEZyKtcx3MG4453OIUYCDUYmHN8IrL0KI
        NbGsuDL3EKMEB7OSCG81f36EEG9KYmVValF+fFFpTmrxIUZTYPRMZJYSTc4H5om8knhDEzND
        EyMTQ0NzIwMjJXHexY3WEUIC6YklqdmpqQWpRTB9TBycUg2MKtsv7Jp4ymf1USdlxU5f1/P2
        wkIex+eseTn9bspc19CuK5vCXpeEae5mdbomYKxhNWv7MzU7hVVnGJtaGGY0/LvrknGdeVWo
        nctGK1nWm1MNLnxZYC9lG5zsvb/218+uT6/mVnVND371xjnlUMT2zis8LK+9PpcZzn03b46b
        4OG+pjWFLf8TlFiKMxINtZiLihMB1uHkdNsDAAA=
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrBIsWRmVeSWpSXmKPExsVy+t9jQd0iofwIgxO/ZS3mHznHavHm+HQm
        i0XvZ7BanJr8jMliyZVD7BY9tzqYLDY9vsZqcXnXHDaLng1bgazmi4wWS69fZLJoajG2WP2s
        wqJ17xF2izNzN7BaLHz6ncVBwGPNvDWMHjtn3WX32LSqk81j85J6j5aT+1k8lryx9tjSDxR+
        v+8qm8fnTXIep75+Zg/ginKzyUhNTEktUkjNS85PycxLt1UKDXHTtVBSyEvMTbVVitD1DQlS
        UihLzCkF8owM0ICDc4B7sJK+XYJbRsutg0wF95gruuYtYW1gbGTuYuTkkBAwkWjbu5kdwhaT
        uHBvPVsXIxeHkMAsRomVD2Gcj4wS9z6vYwWpYhFQlVh/dzIbiM0moCnRdPsHmC0iICWxtesT
        E0gDs0A7s0TfuTNgK4QFQiU2vFkKVMTBwStgK7H3kDDE0KuMEmvmzAJr5hUQlPgx+R4LiM0s
        oCWxfudxJghbWuLR3xlg53EKuElsPNYOZosKqEh0HXrGMoER6E6E9llI2mchaV/AyLyKUSK1
        ILmgOCk91zAvtVyvODG3uDQvXS85P3cTIzjWn0ntYDy4y/0QowAHoxIPb4RXXoQQa2JZcWXu
        IUYJDmYlEd5q/vwIId6UxMqq1KL8+KLSnNTiQ4ymwBCZyCwlmpwPTEN5JfGGJuYm5sYGFuaW
        liZGSuK8jbOfhQsJpCeWpGanphakFsH0MXFwSjUwznA5/d1ry3U3wUZukydct88s62Q2FHBK
        XMm08eokNmFWmZMhc6IMsp2aX6Q/z14rn6Ua3B/p7V4hr80czJz+1nvrbIFFz4V0VuXc8WIJ
        d93aoqetk2OYw2LX5P2wjsE3cI6w6RtNrpy2lpDVZfxnzb6/EWKfY7nzuvvdzgyz52sdZ+y5
        LqvEUpyRaKjFXFScCACu2MeiCwMAAA==
X-MTR: 20000000000000000@CPGS
X-CMS-MailID: 20170106034346epcas1p15c82c18eb686b3bdc4545ec914dac9f3
X-Msg-Generator: CA
X-Sender-IP: 203.254.230.26
X-Local-Sender: =?UTF-8?B?7JWI65SUG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLzthLAp?=
        =?UTF-8?B?G+yCvOyEseyghOyekBvssYXsnoQ=?=
X-Global-Sender: =?UTF-8?B?QW5kaSBTaHl0aRtUaXplbiBQbGF0Zm9ybSBMYWIuG1NhbXN1?=
        =?UTF-8?B?bmcgRWxlY3Ryb25pY3MbU2VuaW9yIEVuZ2luZWVy?=
X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?=
CMS-TYPE: 101P
DLP-Filter: Pass
X-CFilter-Loop: Reflected
X-HopCount: 7
X-CMS-RootMailID: 20170105160810epcas3p1b7a85197c15fbbe87e08c736259935d6
X-RootMTR: 20170105160810epcas3p1b7a85197c15fbbe87e08c736259935d6
References: <1483632384-8107-1-git-send-email-sean.wang@mediatek.com>
 <CGME20170105160810epcas3p1b7a85197c15fbbe87e08c736259935d6@epcas3p1.samsung.com>
 <1483632384-8107-3-git-send-email-sean.wang@mediatek.com>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Sean,

> +	ir->rc = rc_allocate_device();

Yes, you should use devm_rc_allocate_device(...)

Besides, standing to this patch which is not in yet:

https://lkml.org/lkml/2016/12/18/39

rc_allocate_device should provide the driver type during
allocation, so it should be:

	ir->rc = rc_allocate_device(RC_DRIVER_IR_RAW);

and this line can be removed:

> +	ir->rc->driver_type = RC_DRIVER_IR_RAW;

I don't know when Mauro will take the patch above.

Andi