From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Lukasz Majewski <lukma@denx.de>,
Thierry Reding <thierry.reding@gmail.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Stefan Agner <stefan@agner.ch>,
linux-pwm@vger.kernel.org,
Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Lothar Wassmann <LW@karo-electronics.de>,
Sascha Hauer <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
Lukasz Majewski <l.majewski@majess.pl>
Subject: Re: [PATCH v4 07/11] pwm: imx: Provide atomic PWM support for i.MX PWMv2
Date: Fri, 6 Jan 2017 08:06:22 +0100 [thread overview]
Message-ID: <20170106080622.0ded0b6b@bbrezillon> (raw)
In-Reply-To: <CAHp75VdRvFyspu0tAN4xQ_KjyHMMxz0Sy5a4cbea=HTh2WmgRQ@mail.gmail.com>
On Thu, 5 Jan 2017 23:15:06 +0200
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> On Thu, Jan 5, 2017 at 11:19 AM, Boris Brezillon
> <boris.brezillon@free-electrons.com> wrote:
> > On Thu, 5 Jan 2017 10:03:47 +0100
> > Lukasz Majewski <lukma@denx.de> wrote:
> >> > /*
> >> > * Wait for a free FIFO slot if the PWM is already
> >> > enabled, and
> >> > * flush the FIFO if the PWM was disabled and is
> >> > about to be
> >> > * enabled.
> >> > */
>
> >> > if (cstate.enabled) {
>
> if (pwm_is_enabled()) ?
>
> I think it's better to do whatever API provides to be less error prone.
Both pwm_is_enabled() and pwm_get_state()+struct pwm_state are part of
the PWM API, and I don't see how 'if (pwm_is_enabled())' is less error
prone than 'if (cstate.enabled)'.
This being said, I don't care much. It's mainly a matter of taste IMO,
so if others agree to switch to pwm_is_enabled() I'm fine with that.
>
> >> > imx_pwm_wait_fifo_slot(chip, pwm);
> >> > } else {
> >> > ret = clk_prepare_enable(imx->clk_per);
> >> > if (ret)
> >> > return ret;
>
> >> if (state.enabled && !cstate.enabled)
> >> clk_preapre_enable();
> >
> > Yep, and that's correct.
>
> !pwm_is_enabled() ?
>
next prev parent reply other threads:[~2017-01-06 7:07 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-04 23:36 [PATCH v4 00/11] pwm: imx: Provide atomic operation for IMX PWM driver Lukasz Majewski
2017-01-04 23:36 ` [PATCH v4 01/11] pwm: print error messages with pr_err() instead of pr_debug() Lukasz Majewski
2017-01-04 23:36 ` [PATCH v4 02/11] pwm: imx: remove ipg clock and enable per clock when required Lukasz Majewski
2017-01-05 7:14 ` Boris Brezillon
2017-01-05 7:26 ` Lukasz Majewski
2017-01-05 8:27 ` Boris Brezillon
2017-01-05 8:32 ` Lukasz Majewski
2017-01-10 17:28 ` Stefan Agner
2017-01-04 23:36 ` [PATCH v4 03/11] pwm: imx: Add separate set of pwm ops for PWMv1 and PWMv2 Lukasz Majewski
2017-01-04 23:36 ` [PATCH v4 04/11] pwm: imx: Rewrite imx_pwm_*_v1 code to facilitate switch to atomic pwm operation Lukasz Majewski
2017-01-04 23:36 ` [PATCH v4 05/11] pwm: imx: Move PWMv2 software reset code to a separate function Lukasz Majewski
2017-01-04 23:36 ` [PATCH v4 06/11] pwm: imx: Move PWMv2 wait for fifo slot " Lukasz Majewski
2017-01-04 23:36 ` [PATCH v4 07/11] pwm: imx: Provide atomic PWM support for i.MX PWMv2 Lukasz Majewski
2017-01-05 8:50 ` Boris Brezillon
2017-01-05 9:03 ` Lukasz Majewski
2017-01-05 9:19 ` Boris Brezillon
2017-01-05 9:35 ` Lukasz Majewski
2017-01-05 9:53 ` Boris Brezillon
2017-01-10 3:14 ` Stefan Agner
2017-01-10 7:59 ` Boris Brezillon
2017-01-05 21:15 ` Andy Shevchenko
2017-01-06 7:06 ` Boris Brezillon [this message]
2017-01-07 18:35 ` Lukasz Majewski
2017-01-04 23:36 ` [PATCH v4 08/11] pwm: imx: Remove redundant i.MX PWMv2 code Lukasz Majewski
2017-01-04 23:36 ` [PATCH v4 09/11] pwm: core: make the PWM_POLARITY flag in DTB optional Lukasz Majewski
2017-01-04 23:36 ` [PATCH v4 10/11] pwm: imx: doc: Update imx-pwm.txt documentation entry Lukasz Majewski
2017-01-04 23:36 ` [PATCH v4 11/11] pwm: imx: Add polarity inversion support to i.MX's PWMv2 Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170106080622.0ded0b6b@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=LW@karo-electronics.de \
--cc=andy.shevchenko@gmail.com \
--cc=bhuvanchandra.dv@toradex.com \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=l.majewski@majess.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=lukma@denx.de \
--cc=s.hauer@pengutronix.de \
--cc=stefan@agner.ch \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).