From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756012AbdAFOTn (ORCPT ); Fri, 6 Jan 2017 09:19:43 -0500 Received: from mx0b-001ae601.pphosted.com ([67.231.152.168]:41087 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751129AbdAFOSy (ORCPT ); Fri, 6 Jan 2017 09:18:54 -0500 Authentication-Results: ppops.net; spf=none smtp.mailfrom=ckeepax@opensource.wolfsonmicro.com Date: Fri, 6 Jan 2017 14:19:47 +0000 From: Charles Keepax To: CC: , Subject: Re: [PATCH 3/4] mfd: arizona: Update arizona_poll_reg to take a timeout in milliseconds Message-ID: <20170106141947.GB27100@localhost.localdomain> References: <1483711896-29268-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> <1483711896-29268-3-git-send-email-ckeepax@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1483711896-29268-3-git-send-email-ckeepax@opensource.wolfsonmicro.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1612050000 definitions=main-1701060226 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 06, 2017 at 02:11:35PM +0000, Charles Keepax wrote: > Currently, we specify the timeout in terms of the number of polls but it > is more clear from a user of the functions perspective to specify the > timeout directly in milliseconds, as such update the function to these new > semantics. > > Signed-off-by: Charles Keepax > --- > drivers/mfd/arizona-core.c | 17 +++++++++++------ > 1 file changed, 11 insertions(+), 6 deletions(-) > > diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c > index 4cb34c3..1307294 100644 > --- a/drivers/mfd/arizona-core.c > +++ b/drivers/mfd/arizona-core.c > @@ -235,14 +235,18 @@ static irqreturn_t arizona_overclocked(int irq, void *data) > return IRQ_HANDLED; > } > > +#define ARIZONA_REG_POLL_DELAY_MS 5 > + > static int arizona_poll_reg(struct arizona *arizona, > - int timeout, unsigned int reg, > + int timeout_ms, unsigned int reg, > unsigned int mask, unsigned int target) > { > + unsigned int npolls = (timeout_ms + ARIZONA_REG_POLL_DELAY_MS - 1) / > + ARIZONA_REG_POLL_DELAY_MS; > unsigned int val = 0; > int ret, i; > > - for (i = 0; i < timeout; i++) { > + for (i = 0; i < npolls; i++) { > ret = regmap_read(arizona->regmap, reg, &val); > if (ret != 0) { > dev_err(arizona->dev, "Failed to read reg 0x%x: %d\n", > @@ -253,7 +257,8 @@ static int arizona_poll_reg(struct arizona *arizona, > if ((val & mask) == target) > return 0; > > - usleep_range(1000, 5000); > + usleep_range((ARIZONA_REG_POLL_DELAY_MS * 1000) / 2, > + ARIZONA_REG_POLL_DELAY_MS); Oops sorry let me send another version missing a * 1000 here. Thanks, Charles