From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755777AbdAFVE1 (ORCPT <rfc822;w@1wt.eu>);
        Fri, 6 Jan 2017 16:04:27 -0500
Received: from mx1.redhat.com ([209.132.183.28]:49556 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752099AbdAFVET (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 6 Jan 2017 16:04:19 -0500
Date: Fri, 6 Jan 2017 15:04:11 -0600
From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Miroslav Benes <mbenes@suse.cz>
Cc: Jessica Yu <jeyu@redhat.com>, Jiri Kosina <jikos@kernel.org>,
        Petr Mladek <pmladek@suse.com>, linux-kernel@vger.kernel.org,
        live-patching@vger.kernel.org, Michael Ellerman <mpe@ellerman.id.au>,
        Heiko Carstens <heiko.carstens@de.ibm.com>, x86@kernel.org,
        linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org,
        Vojtech Pavlik <vojtech@suse.com>, Jiri Slaby <jslaby@suse.cz>,
        Chris J Arges <chris.j.arges@canonical.com>,
        Andy Lutomirski <luto@kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH v3 15/15] livepatch: allow removal of a disabled patch
Message-ID: <20170106210411.er57shthgit7bqx3@treble>
References: <cover.1481220077.git.jpoimboe@redhat.com>
 <21cb19ed5a44e876aeb830fdea1fad2c795a63f5.1481220077.git.jpoimboe@redhat.com>
 <alpine.LSU.2.20.1701041554270.6852@pobox.suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <alpine.LSU.2.20.1701041554270.6852@pobox.suse.cz>
User-Agent: Mutt/1.6.0.1 (2016-04-01)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Fri, 06 Jan 2017 21:04:20 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jan 04, 2017 at 03:57:09PM +0100, Miroslav Benes wrote:
> 
> > diff --git a/samples/livepatch/livepatch-sample.c b/samples/livepatch/livepatch-sample.c
> > index bb61c65..0625f38 100644
> > --- a/samples/livepatch/livepatch-sample.c
> > +++ b/samples/livepatch/livepatch-sample.c
> > @@ -89,7 +89,6 @@ static int livepatch_init(void)
> >  
> >  static void livepatch_exit(void)
> >  {
> > -	WARN_ON(klp_disable_patch(&patch));
> >  	WARN_ON(klp_unregister_patch(&patch));
> >  }
> 
> Btw, we remove the only call to klp_disable_patch() here. Maybe we can 
> remove the function completely. It is not needed anywhere.

Maybe so.  I haven't heard of anybody needing this interface.

-- 
Josh