From: "Linus Lüssing" <linus.luessing@c0d3.blue>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
linux-wireless@vger.kernel.org, Felix Fietkau <nbd@nbd.name>
Subject: Re: [PATCH net-next] bridge: multicast to unicast
Date: Sat, 7 Jan 2017 16:06:34 +0100 [thread overview]
Message-ID: <20170107150634.GF3134@otheros> (raw)
In-Reply-To: <20170106191356.43740a26@xeon-e3>
On Fri, Jan 06, 2017 at 07:13:56PM -0800, Stephen Hemminger wrote:
> On Mon, 2 Jan 2017 20:32:14 +0100
> Linus Lüssing <linus.luessing@c0d3.blue> wrote:
>
> > This feature is intended for interface types which have a more reliable
> > and/or efficient way to deliver unicast packets than broadcast ones
> > (e.g. wifi).
>
>
> Why is this not done in MAC80211 rather than bridge?
Because mac80211 does not have the IGMP/MLD snooping code as
the bridge has?
Reimplementing the snooping in mac80211 does not make sense
because of duplicating code. Moving the snooping code from the
bridge to mac80211 does not make sense either, because we want
multicast snooping, software based, (virtually) wired switches,
too.
The "best way" (TM) would probably be to migrate the IGMP/MLD
snooping from the bridge code to the net device code on the long
run to make such a database usable for any kind of device, without
needing this bridge hack.
But such a migration would also need a way more invasive patchset.
While Felix's idea might look a little "ugly" due it's hacky
nature, I think it is also quite beautiful thanks to it's
simplicity.
next prev parent reply other threads:[~2017-01-07 15:06 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-02 19:32 [PATCH net-next] bridge: multicast to unicast Linus Lüssing
2017-01-03 11:58 ` Nikolay Aleksandrov
2017-01-03 13:15 ` Felix Fietkau
2017-01-06 12:47 ` Johannes Berg
2017-01-06 13:52 ` Felix Fietkau
2017-01-06 13:54 ` Johannes Berg
2017-01-06 13:54 ` Felix Fietkau
2017-01-07 10:32 ` M. Braun
2017-01-07 14:55 ` Linus Lüssing
2017-01-09 8:08 ` Johannes Berg
2017-01-09 11:44 ` M. Braun
2017-01-09 12:15 ` Johannes Berg
2017-01-09 15:25 ` michael-dev
2017-01-09 15:47 ` Johannes Berg
2017-01-09 21:23 ` Linus Lüssing
2017-01-09 21:30 ` Stephen Hemminger
2017-01-10 4:18 ` Linus Lüssing
2017-01-10 10:56 ` Johannes Berg
2017-01-10 17:17 ` Dave Taht
2017-01-10 17:23 ` Felix Fietkau
2017-01-10 18:24 ` Dave Taht
2017-01-10 21:27 ` Felix Fietkau
2017-01-11 11:26 ` IgorMitsyanko
2017-01-11 11:30 ` Felix Fietkau
2017-01-11 12:15 ` IgorMitsyanko
2017-01-11 12:21 ` Felix Fietkau
2017-01-07 15:15 ` Linus Lüssing
2017-01-09 8:05 ` Johannes Berg
2017-01-09 12:42 ` Linus Lüssing
2017-01-09 12:44 ` Johannes Berg
2017-01-09 23:12 ` Linus Lüssing
2017-01-11 9:17 ` Johannes Berg
2017-01-07 3:13 ` Stephen Hemminger
2017-01-07 15:06 ` Linus Lüssing [this message]
2017-01-09 8:36 ` Jean-Pierre Tosoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170107150634.GF3134@otheros \
--to=linus.luessing@c0d3.blue \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).