From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S968396AbdAHS5v (ORCPT ); Sun, 8 Jan 2017 13:57:51 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59744 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S968308AbdAHS5o (ORCPT ); Sun, 8 Jan 2017 13:57:44 -0500 Date: Sun, 8 Jan 2017 19:57:41 +0100 From: Jiri Olsa To: Andi Kleen Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org, mingo@kernel.org, Andi Kleen Subject: Re: [PATCH 02/11] perf, tools: Parse eventcode as number in jevents Message-ID: <20170108185741.GA14072@krava> References: <20170103150833.6694-1-andi@firstfloor.org> <20170103150833.6694-3-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170103150833.6694-3-andi@firstfloor.org> User-Agent: Mutt/1.7.1 (2016-10-04) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Sun, 08 Jan 2017 18:57:44 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 03, 2017 at 07:08:24AM -0800, Andi Kleen wrote: > From: Andi Kleen > > The next patch needs to modify event code. Previously eventcode was just > passed through as a string. Now parse it as a number. > > Signed-off-by: Andi Kleen > --- > tools/perf/pmu-events/jevents.c | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/tools/perf/pmu-events/jevents.c b/tools/perf/pmu-events/jevents.c > index 41611d7f9873..ee5eeeaed378 100644 > --- a/tools/perf/pmu-events/jevents.c > +++ b/tools/perf/pmu-events/jevents.c > @@ -135,7 +135,6 @@ static struct field { > const char *field; > const char *kernel; > } fields[] = { > - { "EventCode", "event=" }, > { "UMask", "umask=" }, > { "CounterMask", "cmask=" }, > { "Invert", "inv=" }, > @@ -164,6 +163,10 @@ static int match_field(char *map, jsmntok_t *field, int nz, > > for (f = fields; f->field; f++) > if (json_streq(map, field, f->field) && nz) { > + /* Handle all variations of 0 encounted in JSON */ > + if (json_streq(map, val, "0x00") || > + json_streq(map, val, "0x0")) > + return 1; how is this related to the patch? also shouldn't it return 0 ? jirka