From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756988AbdAHTA7 (ORCPT <rfc822;w@1wt.eu>);
        Sun, 8 Jan 2017 14:00:59 -0500
Received: from mx1.redhat.com ([209.132.183.28]:59598 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753785AbdAHTA6 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 8 Jan 2017 14:00:58 -0500
Date: Sun, 8 Jan 2017 20:00:55 +0100
From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org,
        mingo@kernel.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 03/11] perf, tools: Add support for parsing uncore json
 files
Message-ID: <20170108190055.GA14867@krava>
References: <20170103150833.6694-1-andi@firstfloor.org>
 <20170103150833.6694-4-andi@firstfloor.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170103150833.6694-4-andi@firstfloor.org>
User-Agent: Mutt/1.7.1 (2016-10-04)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Sun, 08 Jan 2017 19:00:59 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jan 03, 2017 at 07:08:25AM -0800, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
> 
> Handle the Unit field, which is needed to find the right PMU for
> an event. We call it "pmu" and convert it to the perf pmu name
> with an uncore prefix.
> 
> Handle the ExtSel field, which just extends the event mask with
> an additional bit.
> 
> Handle the Filter field which adds parameters to the main event
> to configure filtering.
> 
> Handle the Unit field which declares the unit the values
> should be scaled too (similar to what the kernel exports)
> 
> Set up the perpkg field for uncore events so that perf
> knows they are per package (similar to what the kernel exports)
> 
> Then output the fields into the pmu-events data structures which
> are compiled into perf.
> 
> Filter out zero fields, except for the event itself.
> 
> v2: Fix compilation. Add uncore_ prefix at pre-processing time.
> Move eventcode change to separate patch.
> Signed-off-by: Andi Kleen <ak@linux.intel.com>

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka