From: Petr Mladek <pmladek@suse.com>
To: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Steven Rostedt <rostedt@goodmis.org>,
Peter Hurley <peter@hurleysoftware.com>,
linux-kernel@vger.kernel.org,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Subject: Re: [PATCH 1/2] printk: drop call_console_drivers() unused param
Date: Mon, 9 Jan 2017 14:49:59 +0100 [thread overview]
Message-ID: <20170109134958.GD20785@pathway.suse.cz> (raw)
In-Reply-To: <20170103102230.GK14894@pathway.suse.cz>
On Tue 2017-01-03 11:22:30, Petr Mladek wrote:
> On Sat 2016-12-24 23:09:01, Sergey Senozhatsky wrote:
> > We do suppress_message_printing() check before we call
> > call_console_drivers() now, so `level' param is not needed
> > anymore.
> >
> > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> > ---
> > kernel/printk/printk.c | 12 ++++--------
> > 1 file changed, 4 insertions(+), 8 deletions(-)
> >
> > diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
> > index e2cdd87e7a63..11a9842a2f47 100644
> > --- a/kernel/printk/printk.c
> > +++ b/kernel/printk/printk.c
> > @@ -1510,8 +1510,7 @@ SYSCALL_DEFINE3(syslog, int, type, char __user *, buf, int, len)
> > * log_buf[start] to log_buf[end - 1].
> > * The console_lock must be held.
> > */
> > -static void call_console_drivers(int level,
> > - const char *ext_text, size_t ext_len,
> > +static void call_console_drivers(const char *ext_text, size_t ext_len,
> > const char *text, size_t len)
>
> Yup, this patch makes sense on its own. The level parameter is unused
> since the commit cf7754441c563230ed7 ("printk: introduce
> suppress_message_printing()").
>
> Reviewed-by: Petr Mladek <pmladek@suse.com>
The patch makes sense on its own. I have pushed it into
the for-4.11 branch, see
https://git.kernel.org/cgit/linux/kernel/git/pmladek/printk.git/commit/?h=for-4.11&id=0e91b77060387275b6762c6688e3bddd1b808e2c
Best Regards,
Petr
next prev parent reply other threads:[~2017-01-09 13:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-24 14:09 [PATCH 0/2] printk: always report dropped messages Sergey Senozhatsky
2016-12-24 14:09 ` [PATCH 1/2] printk: drop call_console_drivers() unused param Sergey Senozhatsky
2017-01-03 10:22 ` Petr Mladek
2017-01-09 13:49 ` Petr Mladek [this message]
2016-12-24 14:09 ` [PATCH 2/2] printk: always report lost messages on serial console Sergey Senozhatsky
2017-01-03 14:55 ` Petr Mladek
2017-01-03 15:47 ` Sergey Senozhatsky
2017-01-03 16:53 ` Petr Mladek
2017-01-04 2:46 ` Sergey Senozhatsky
2017-01-04 10:52 ` Petr Mladek
2017-01-04 13:34 ` Sergey Senozhatsky
2017-01-04 15:26 ` Petr Mladek
2017-01-05 2:30 ` Sergey Senozhatsky
2017-01-05 10:53 ` Petr Mladek
2017-01-09 16:56 ` Petr Mladek
2017-01-10 8:49 ` Sergey Senozhatsky
2017-01-11 16:50 ` Petr Mladek
2017-01-13 5:11 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170109134958.GD20785@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter@hurleysoftware.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).