From: Michal Hocko <mhocko@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
Tom Herbert <tom@herbertland.com>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: weird allocation pattern in alloc_ila_locks
Date: Mon, 9 Jan 2017 15:41:59 +0100 [thread overview]
Message-ID: <20170109144158.GM7495@dhcp22.suse.cz> (raw)
In-Reply-To: <CANn89iLoC6uL8rfr_GWfuPeKasgw=JiuciSDN6EQBC0yFsgbww@mail.gmail.com>
On Mon 09-01-17 06:31:50, Eric Dumazet wrote:
> On Mon, Jan 9, 2017 at 1:58 AM, Michal Hocko <mhocko@kernel.org> wrote:
>
> >
> > Also this seems to be an init code so I assume a modprobe would have to
> > set a non-default policy to make use of it. Does anybody do that out
> > there?
>
> This is not init code. Whole point of rhashtable is that the resizes
> can happen anytime.
> At boot time, most rhashtable would be tiny.
> Then, when load permits, hashtables grow in size.
OK, we are mixing two things here. I was talking about alloc_ila_locks
which is an init code AFAIU.
If you are talking about alloc_bucket_locks then I would argue that the
current code doesn't work as expected as the rehash happens from a
kernel worker context and so the numa policy is out of control.
I will reply to this email with the patches I have pending here and plan
to post just to make sure we are at the same page.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2017-01-09 14:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-06 9:51 weird allocation pattern in alloc_ila_locks Michal Hocko
2017-01-06 10:04 ` Michal Hocko
2017-01-06 12:16 ` Michal Hocko
2017-01-06 22:14 ` Eric Dumazet
2017-01-07 9:27 ` Michal Hocko
2017-01-07 18:37 ` Eric Dumazet
2017-01-09 9:58 ` Michal Hocko
2017-01-09 14:31 ` Eric Dumazet
2017-01-09 14:41 ` Michal Hocko [this message]
2017-01-09 14:43 ` [PATCH 1/2] rhashtable: simplify a strange allocation pattern Michal Hocko
2017-01-09 14:43 ` [PATCH 2/2] ila: " Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170109144158.GM7495@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).