From: Tony Lindgren <tony@atomide.com>
To: Sarangdhar Joshi <spjoshi@codeaurora.org>
Cc: Ohad Ben-Cohen <ohad@wizery.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Santosh Shilimkar <ssantosh@kernel.org>,
Trilok Soni <tsoni@codeaurora.org>,
linux-arm-msm@vger.kernel.org, Dave Gerlach <d-gerlach@ti.com>,
Stephen Boyd <sboyd@codeaurora.org>,
linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3] soc: ti: wkup_m3_ipc: Drop wait from wkup_m3_rproc_boot_thread
Date: Mon, 9 Jan 2017 11:33:28 -0800 [thread overview]
Message-ID: <20170109193328.GO2630@atomide.com> (raw)
In-Reply-To: <1483653615-24378-1-git-send-email-spjoshi@codeaurora.org>
* Sarangdhar Joshi <spjoshi@codeaurora.org> [170105 14:01]:
> The function wkup_m3_rproc_boot_thread waits for asynchronous
> firmware loading to parse the resource table before calling
> rproc_boot(). However, as the resource table parsing has been
> moved to rproc_boot(), there's no need to wait for the
> asynchronous firmware loading completion. So, drop this.
>
> CC: Dave Gerlach <d-gerlach@ti.com>
> CC: Bjorn Andersson <bjorn.andersson@linaro.org>
> Tested-by: Suman Anna <s-anna@ti.com>
> Signed-off-by: Sarangdhar Joshi <spjoshi@codeaurora.org>
> ---
>
> This patch seems to be doing an independent clean up now. Hence
> removing it from the series.
>
> Changes from v2:
>
> * Updated the subject line as per Suman's comment
FYI, I already have v2 applied with subject:
"soc: ti: wkup_m3_ipc: Drop wait from wkup_m3_rproc_boot_thread"
Tony
> drivers/soc/ti/wkup_m3_ipc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/soc/ti/wkup_m3_ipc.c b/drivers/soc/ti/wkup_m3_ipc.c
> index 8823cc8..8bfa44b 100644
> --- a/drivers/soc/ti/wkup_m3_ipc.c
> +++ b/drivers/soc/ti/wkup_m3_ipc.c
> @@ -370,8 +370,6 @@ static void wkup_m3_rproc_boot_thread(struct wkup_m3_ipc *m3_ipc)
> struct device *dev = m3_ipc->dev;
> int ret;
>
> - wait_for_completion(&m3_ipc->rproc->firmware_loading_complete);
> -
> init_completion(&m3_ipc->sync_complete);
>
> ret = rproc_boot(m3_ipc->rproc);
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
next prev parent reply other threads:[~2017-01-09 19:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-05 22:00 [PATCH v3] soc: ti: wkup_m3_ipc: Drop wait from wkup_m3_rproc_boot_thread Sarangdhar Joshi
2017-01-06 16:38 ` Tony Lindgren
2017-01-09 19:33 ` Tony Lindgren [this message]
2017-01-09 19:39 ` Sarangdhar Joshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170109193328.GO2630@atomide.com \
--to=tony@atomide.com \
--cc=bjorn.andersson@linaro.org \
--cc=d-gerlach@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=sboyd@codeaurora.org \
--cc=spjoshi@codeaurora.org \
--cc=ssantosh@kernel.org \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).