From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S940606AbdAIURT (ORCPT ); Mon, 9 Jan 2017 15:17:19 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:37633 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S938472AbdAIURP (ORCPT ); Mon, 9 Jan 2017 15:17:15 -0500 Date: Mon, 9 Jan 2017 12:17:13 -0800 From: Guenter Roeck To: Linus Walleij Cc: Wim Van Sebroeck , "linux-arm-kernel@lists.infradead.org" , linux-watchdog@vger.kernel.org, "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/4] watchdog: coh901327_wdt: Simplify error handling in probe function Message-ID: <20170109201713.GB8668@roeck-us.net> References: <1483500343-27113-1-git-send-email-linux@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=1.5 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 09, 2017 at 08:38:03PM +0100, Linus Walleij wrote: > On Wed, Jan 4, 2017 at 4:25 AM, Guenter Roeck wrote: > > > Checking if there is no error followed by a goto if there is one is > > confusing. Reverse the logic. > > > > Signed-off-by: Guenter Roeck > > Reviewed-by: Linus Walleij > Thanks! Guenter