From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941558AbdAIVql (ORCPT ); Mon, 9 Jan 2017 16:46:41 -0500 Received: from mail-qk0-f195.google.com ([209.85.220.195]:32770 "EHLO mail-qk0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933850AbdAIVqh (ORCPT ); Mon, 9 Jan 2017 16:46:37 -0500 Date: Mon, 9 Jan 2017 16:46:35 -0500 From: Tejun Heo To: Shaohua Li Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com, axboe@fb.com, vgoyal@redhat.com Subject: Re: [PATCH V5 00/17] blk-throttle: add .low limit Message-ID: <20170109214635.GV12827@mtj.duckdns.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Sorry about the long delay. Generally looks good to me. Overall, there are only a few things that I think should be addressed. * Low limit should default to zero. * The default values and roles of idle timeout vs. latency target. I don't think either would be difficult to address. Oh and a bit more documentation overall would be nice. Thanks a lot for the great work and happy new year! -- tejun