From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756235AbdAJGML (ORCPT <rfc822;w@1wt.eu>);
        Tue, 10 Jan 2017 01:12:11 -0500
Received: from wtarreau.pck.nerim.net ([62.212.114.60]:28601 "EHLO 1wt.eu"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753245AbdAJGMJ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 10 Jan 2017 01:12:09 -0500
Date: Tue, 10 Jan 2017 07:11:50 +0100
From: Willy Tarreau <w@1wt.eu>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, jolsa@kernel.org, mingo@kernel.org,
        linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 1/5] perf, tools: Add probing for xed
Message-ID: <20170110061150.GB4450@1wt.eu>
References: <20170110010225.24870-1-andi@firstfloor.org>
 <20170110010225.24870-2-andi@firstfloor.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170110010225.24870-2-andi@firstfloor.org>
User-Agent: Mutt/1.6.1 (2016-04-27)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Andi,

just a very minor cosmetic detail, but your editor seems to use tabs while
there were 8 spaces around, causing visual alignment defects below :

On Mon, Jan 09, 2017 at 05:02:21PM -0800, Andi Kleen wrote:
> diff --git a/tools/build/Makefile.feature b/tools/build/Makefile.feature
> index e3fb5ecbdcb6..971a9ef87ca6 100644
> --- a/tools/build/Makefile.feature
> +++ b/tools/build/Makefile.feature
> @@ -63,7 +63,7 @@ FEATURE_TESTS_BASIC :=                  \
>          lzma                            \
>          get_cpuid                       \
>          bpf                             \
> -        sdt
> +	sdt				\

here

>  # FEATURE_TESTS_BASIC + FEATURE_TESTS_EXTRA is the complete list
>  # of all feature tests
> @@ -74,11 +74,12 @@ FEATURE_TESTS_EXTRA :=                  \
>           cplus-demangle                 \
>           hello                          \
>           libbabeltrace                  \
> +	 xed				\

here

>           liberty                        \
>           liberty-z                      \
>           libunwind-debug-frame          \
>           libunwind-debug-frame-arm      \
> -         libunwind-debug-frame-aarch64
> +	 libunwind-debug-frame-aarch64

here

>  
>  FEATURE_TESTS ?= $(FEATURE_TESTS_BASIC)
>  
> @@ -105,7 +106,7 @@ FEATURE_DISPLAY ?=              \
>           zlib                   \
>           lzma                   \
>           get_cpuid              \
> -         bpf
> +	 bpf

and here.

I think it would be nice to fix them before merging.

Did I say it was very minor ? :-)

Regards,
Willy