From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Punnaiah Choudary Kalluri <punnaiah.choudary.kalluri@xilinx.com>
Cc: Rob Herring <robh@kernel.org>,
"dwmw2@infradead.org" <dwmw2@infradead.org>,
"computersforpeace@gmail.com" <computersforpeace@gmail.com>,
"marek.vasut@gmail.com" <marek.vasut@gmail.com>,
"richard@nod.at" <richard@nod.at>,
"cyrille.pitchen@atmel.com" <cyrille.pitchen@atmel.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Michal Simek <michals@xilinx.com>,
"kalluripunnaiahchoudary@gmail.com"
<kalluripunnaiahchoudary@gmail.com>,
"kpc528@gmail.com" <kpc528@gmail.com>
Subject: Re: [PATCH v7 1/2] mtd: arasan: Add device tree binding documentation
Date: Tue, 10 Jan 2017 09:06:21 +0100 [thread overview]
Message-ID: <20170110090621.09d08cfa@bbrezillon> (raw)
In-Reply-To: <03CA77BA8AF6F1469AEDFBDA1322A7B76424ECD2@XAP-PVEXMBX02.xlnx.xilinx.com>
Hi Punnaiah,
On Tue, 10 Jan 2017 06:03:25 +0000
Punnaiah Choudary Kalluri <punnaiah.choudary.kalluri@xilinx.com> wrote:
> Hi Rob,
>
> Thanks for the review.
>
> > -----Original Message-----
> > From: Rob Herring [mailto:robh@kernel.org]
> > Sent: Tuesday, January 10, 2017 11:06 AM
> > To: Punnaiah Choudary Kalluri <punnaia@xilinx.com>
> > Cc: dwmw2@infradead.org; computersforpeace@gmail.com;
> > boris.brezillon@free-electrons.com; marek.vasut@gmail.com;
> > richard@nod.at; cyrille.pitchen@atmel.com; mark.rutland@arm.com; linux-
> > kernel@vger.kernel.org; linux-mtd@lists.infradead.org;
> > devicetree@vger.kernel.org; Michal Simek <michals@xilinx.com>;
> > kalluripunnaiahchoudary@gmail.com; kpc528@gmail.com; Punnaiah
> > Choudary Kalluri <punnaia@xilinx.com>
> > Subject: Re: [PATCH v7 1/2] mtd: arasan: Add device tree binding
> > documentation
> >
> > On Mon, Jan 09, 2017 at 08:28:53AM +0530, Punnaiah Choudary Kalluri wrote:
> > > This patch adds the dts binding document for arasan nand flash
> > > controller.
> > >
> > > Signed-off-by: Punnaiah Choudary Kalluri <punnaia@xilinx.com>
> > > ---
> > > Changes in v7:
> > > - Corrected the acronyms those should be in caps
> > > changes in v6:
> > > - Removed num-cs property
> > > - Separated nandchip from nand controller
> > > changes in v5:
> > > - None
> > > Changes in v4:
> > > - Added num-cs property
> > > - Added clock support
> > > Changes in v3:
> > > - None
> > > Changes in v2:
> > > - None
> > > ---
> > > .../devicetree/bindings/mtd/arasan_nfc.txt | 38
> > ++++++++++++++++++++++
> > > 1 file changed, 38 insertions(+)
> > > create mode 100644
> > Documentation/devicetree/bindings/mtd/arasan_nfc.txt
> > >
> > > diff --git a/Documentation/devicetree/bindings/mtd/arasan_nfc.txt
> > b/Documentation/devicetree/bindings/mtd/arasan_nfc.txt
> > > new file mode 100644
> > > index 0000000..f20adfc
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/mtd/arasan_nfc.txt
> > > @@ -0,0 +1,38 @@
> > > +Arasan NAND Flash Controller with ONFI 3.1 support
> > > +
> > > +Required properties:
> > > +- compatible: Should be "arasan,nfc-v3p10"
> >
> > Needs a note that it must also have an SoC specific compatible string.
> >
> Sorry, I couldn't understand this comment. Could you elaborate it?
Arasan is an IP vendor, and those IPs are usually embedded in specific
SoCs. I guess Rob was suggesting to define something like:
compatible = "<soc-vendor>,<ip-revision>", "arasan,<ip-revision>";
This way you can differentiate minor changes/tweaks between each SoC
(each SoC vendor usually enable/disable specific features based on
their needs).
>
> > > +- reg: Memory map for module access
> > > +- interrupt-parent: Interrupt controller the interrupt is routed through
> > > +- interrupts: Should contain the interrupt for the device
> > > +- clock-name: List of input clocks - "clk_sys", "clk_flash"
> >
> > clk_ is redundant.
> >
>
> I have defined these clock names as per the controller data sheet.
> So, I feel it is fine to have them in sync with the datasheet.
> Please let me know if you still want me to change this.
We already know this is a clock, hence the unneeded clk_ prefix. Please
drop it.
Thanks,
Boris
next prev parent reply other threads:[~2017-01-10 8:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-09 2:58 [PATCH v7 1/2] mtd: arasan: Add device tree binding documentation Punnaiah Choudary Kalluri
2017-01-09 2:58 ` [PATCH v7 2/2] mtd: nand: Add support for Arasan NAND Flash Controller Punnaiah Choudary Kalluri
2017-02-19 10:26 ` Boris Brezillon
2017-02-25 3:06 ` punnaiah choudary kalluri
2017-01-10 5:36 ` [PATCH v7 1/2] mtd: arasan: Add device tree binding documentation Rob Herring
2017-01-10 6:03 ` Punnaiah Choudary Kalluri
2017-01-10 8:06 ` Boris Brezillon [this message]
2017-01-10 8:48 ` Punnaiah Choudary Kalluri
2017-01-10 9:16 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170110090621.09d08cfa@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@atmel.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=kalluripunnaiahchoudary@gmail.com \
--cc=kpc528@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=mark.rutland@arm.com \
--cc=michals@xilinx.com \
--cc=punnaiah.choudary.kalluri@xilinx.com \
--cc=richard@nod.at \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).