* [PATCH] scsi: qedi: select UIO
@ 2017-01-10 15:27 Arnd Bergmann
2017-01-10 18:44 ` Johannes Thumshirn
2017-01-10 20:19 ` Ewan D. Milne
0 siblings, 2 replies; 5+ messages in thread
From: Arnd Bergmann @ 2017-01-10 15:27 UTC (permalink / raw)
To: James E.J. Bottomley, Martin K. Petersen
Cc: Arnd Bergmann, QLogic-Storage-Upstream, Johannes Thumshirn,
Nilesh Javali, Adheer Chandravanshi, Manish Rangankar,
linux-scsi, linux-kernel
The newly added qedi driver links against the UIO framework, but can
be built without that:
drivers/scsi/qedi/qedi_main.o: In function `qedi_free_uio':
qedi_main.c:(.text.qedi_free_uio+0x78): undefined reference to `uio_unregister_device'
drivers/scsi/qedi/qedi_main.o: In function `qedi_ll2_recv_thread':
qedi_main.c:(.text.qedi_ll2_recv_thread+0x18c): undefined reference to `uio_event_notify'
drivers/scsi/qedi/qedi_main.o: In function `__qedi_probe.constprop.1':
qedi_main.c:(.text.__qedi_probe.constprop.1+0x1368): undefined reference to `__uio_register_device'
This adds a compile-time dependency.
Fixes: ace7f46ba5fd ("scsi: qedi: Add QLogic FastLinQ offload iSCSI driver framework.")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/scsi/qedi/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/qedi/Kconfig b/drivers/scsi/qedi/Kconfig
index 23ca8a274586..913610f3d274 100644
--- a/drivers/scsi/qedi/Kconfig
+++ b/drivers/scsi/qedi/Kconfig
@@ -2,6 +2,7 @@ config QEDI
tristate "QLogic QEDI 25/40/100Gb iSCSI Initiator Driver Support"
depends on PCI && SCSI
depends on QED
+ depends on UIO
select SCSI_ISCSI_ATTRS
select QED_LL2
select QED_ISCSI
--
2.9.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] scsi: qedi: select UIO
2017-01-10 15:27 [PATCH] scsi: qedi: select UIO Arnd Bergmann
@ 2017-01-10 18:44 ` Johannes Thumshirn
2017-01-10 20:19 ` Ewan D. Milne
1 sibling, 0 replies; 5+ messages in thread
From: Johannes Thumshirn @ 2017-01-10 18:44 UTC (permalink / raw)
To: Arnd Bergmann
Cc: James E.J. Bottomley, Martin K. Petersen,
QLogic-Storage-Upstream, Nilesh Javali, Adheer Chandravanshi,
Manish Rangankar, linux-scsi, linux-kernel
On Tue, Jan 10, 2017 at 04:27:29PM +0100, Arnd Bergmann wrote:
> The newly added qedi driver links against the UIO framework, but can
> be built without that:
>
> drivers/scsi/qedi/qedi_main.o: In function `qedi_free_uio':
> qedi_main.c:(.text.qedi_free_uio+0x78): undefined reference to `uio_unregister_device'
> drivers/scsi/qedi/qedi_main.o: In function `qedi_ll2_recv_thread':
> qedi_main.c:(.text.qedi_ll2_recv_thread+0x18c): undefined reference to `uio_event_notify'
> drivers/scsi/qedi/qedi_main.o: In function `__qedi_probe.constprop.1':
> qedi_main.c:(.text.__qedi_probe.constprop.1+0x1368): undefined reference to `__uio_register_device'
>
> This adds a compile-time dependency.
>
> Fixes: ace7f46ba5fd ("scsi: qedi: Add QLogic FastLinQ offload iSCSI driver framework.")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
Looks OK,
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] scsi: qedi: select UIO
2017-01-10 15:27 [PATCH] scsi: qedi: select UIO Arnd Bergmann
2017-01-10 18:44 ` Johannes Thumshirn
@ 2017-01-10 20:19 ` Ewan D. Milne
2017-01-11 4:10 ` Martin K. Petersen
1 sibling, 1 reply; 5+ messages in thread
From: Ewan D. Milne @ 2017-01-10 20:19 UTC (permalink / raw)
To: Arnd Bergmann
Cc: James E.J. Bottomley, Martin K. Petersen,
QLogic-Storage-Upstream, Johannes Thumshirn, Nilesh Javali,
Adheer Chandravanshi, Manish Rangankar, linux-scsi, linux-kernel
On Tue, 2017-01-10 at 16:27 +0100, Arnd Bergmann wrote:
> The newly added qedi driver links against the UIO framework, but can
> be built without that:
>
> drivers/scsi/qedi/qedi_main.o: In function `qedi_free_uio':
> qedi_main.c:(.text.qedi_free_uio+0x78): undefined reference to `uio_unregister_device'
> drivers/scsi/qedi/qedi_main.o: In function `qedi_ll2_recv_thread':
> qedi_main.c:(.text.qedi_ll2_recv_thread+0x18c): undefined reference to `uio_event_notify'
> drivers/scsi/qedi/qedi_main.o: In function `__qedi_probe.constprop.1':
> qedi_main.c:(.text.__qedi_probe.constprop.1+0x1368): undefined reference to `__uio_register_device'
>
> This adds a compile-time dependency.
>
> Fixes: ace7f46ba5fd ("scsi: qedi: Add QLogic FastLinQ offload iSCSI driver framework.")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/scsi/qedi/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/qedi/Kconfig b/drivers/scsi/qedi/Kconfig
> index 23ca8a274586..913610f3d274 100644
> --- a/drivers/scsi/qedi/Kconfig
> +++ b/drivers/scsi/qedi/Kconfig
> @@ -2,6 +2,7 @@ config QEDI
> tristate "QLogic QEDI 25/40/100Gb iSCSI Initiator Driver Support"
> depends on PCI && SCSI
> depends on QED
> + depends on UIO
> select SCSI_ISCSI_ATTRS
> select QED_LL2
> select QED_ISCSI
Randy posted a similar patch back in December but I don't think there
was ever a reply to Christoph's question about why qedi depends on uio.
-Ewan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] scsi: qedi: select UIO
2017-01-10 20:19 ` Ewan D. Milne
@ 2017-01-11 4:10 ` Martin K. Petersen
2017-01-11 9:00 ` Rangankar, Manish
0 siblings, 1 reply; 5+ messages in thread
From: Martin K. Petersen @ 2017-01-11 4:10 UTC (permalink / raw)
To: Ewan D. Milne
Cc: Arnd Bergmann, James E.J. Bottomley, Martin K. Petersen,
QLogic-Storage-Upstream, Johannes Thumshirn, Nilesh Javali,
Adheer Chandravanshi, Manish Rangankar, linux-scsi, linux-kernel
>>>>> "Ewan" == Ewan D Milne <emilne@redhat.com> writes:
Ewan> Randy posted a similar patch back in December but I don't think
Ewan> there was ever a reply to Christoph's question about why qedi
Ewan> depends on uio.
I did queue up Randy's patch to shut up the build warnings. But we're
still looking for a long term fix or an explanation as to why UIO is
needed in the first place.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] scsi: qedi: select UIO
2017-01-11 4:10 ` Martin K. Petersen
@ 2017-01-11 9:00 ` Rangankar, Manish
0 siblings, 0 replies; 5+ messages in thread
From: Rangankar, Manish @ 2017-01-11 9:00 UTC (permalink / raw)
To: Martin K. Petersen, Ewan D. Milne
Cc: Arnd Bergmann, James E.J. Bottomley,
Dept-Eng QLogic Storage Upstream, Johannes Thumshirn, Javali,
Nilesh, linux-scsi, linux-kernel
On 11/01/17 9:40 AM, "Martin K. Petersen" <martin.petersen@oracle.com>
wrote:
>>>>>> "Ewan" == Ewan D Milne <emilne@redhat.com> writes:
>
>Ewan> Randy posted a similar patch back in December but I don't think
>Ewan> there was ever a reply to Christoph's question about why qedi
>Ewan> depends on uio.
>
>I did queue up Randy's patch to shut up the build warnings. But we're
>still looking for a long term fix or an explanation as to why UIO is
>needed in the first place.
Similar to bnx2i driver, qedi driver also has a dependency over iscsiuio
to provide ARP and DHCP functionality for iscsi offload, and the
communication to the
driver is done via uio interface.
https://github.com/open-iscsi/open-iscsi/blob/master/iscsiuio/README
Thanks,
Manish
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-01-11 9:01 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-10 15:27 [PATCH] scsi: qedi: select UIO Arnd Bergmann
2017-01-10 18:44 ` Johannes Thumshirn
2017-01-10 20:19 ` Ewan D. Milne
2017-01-11 4:10 ` Martin K. Petersen
2017-01-11 9:00 ` Rangankar, Manish
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).