linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Roman Sommer <roman.sommer@fau.de>
Cc: linux-kernel@i4.cs.fau.de, Rui Miguel Silva <rmfrfs@gmail.com>,
	Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	greybus-dev@lists.linaro.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org,
	Christian Bewermeyer <christian.bewermeyer@fau.de>
Subject: Re: [PATCH] greybus: checkpatch: Change parameter type unsigned to unsigned int
Date: Tue, 10 Jan 2017 17:40:51 +0100	[thread overview]
Message-ID: <20170110164051.GE3501@localhost> (raw)
In-Reply-To: <1484065284-27211-1-git-send-email-roman.sommer@fau.de>

On Tue, Jan 10, 2017 at 05:21:24PM +0100, Roman Sommer wrote:
> From: Christian Bewermeyer <christian.bewermeyer@fau.de>
> 
> Note that this patch does not fix all checkpatch warnings for
> gpio.c

Fair enough, but you are fixing all of these new "unsigned int"
warnings in that driver, right?

How about fixing the sole remaining instance in the loopback driver so
that this is done for the whole subsystem once and for all?

Also your Subject should be

	staging: greybus: gpio: fix checkpatch unsigned warnings

unless doing this subsystem-wide, in which case you can drop the
"gpio" module prefix.

Thanks,
Johan

  reply	other threads:[~2017-01-10 16:40 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-10 16:21 [PATCH] greybus: checkpatch: Change parameter type unsigned to unsigned int Roman Sommer
2017-01-10 16:40 ` Johan Hovold [this message]
2017-01-10 17:01   ` roman.sommer
2017-01-11 13:48 ` [PATCH v2] " Roman Sommer
2017-01-11 13:52   ` Johan Hovold
2017-01-11 14:44     ` roman.sommer
2017-01-11 14:47       ` roman.sommer
2017-01-11 15:00     ` [PATCH v3] staging: " Roman Sommer
2017-01-11 15:08       ` Johan Hovold
2017-01-12  4:50       ` [greybus-dev] " Viresh Kumar
2017-01-12  7:05       ` Dan Carpenter
2017-01-12  8:47         ` Johan Hovold
2017-01-13 20:54 ` [PATCH] staging: greybus: fix checkpatch unsigned warnings Roman Sommer
2017-01-16  9:50   ` Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170110164051.GE3501@localhost \
    --to=johan@kernel.org \
    --cc=christian.bewermeyer@fau.de \
    --cc=devel@driverdev.osuosl.org \
    --cc=elder@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=greybus-dev@lists.linaro.org \
    --cc=linux-kernel@i4.cs.fau.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmfrfs@gmail.com \
    --cc=roman.sommer@fau.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).