From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938952AbdAJQ67 (ORCPT ); Tue, 10 Jan 2017 11:58:59 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:34394 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934738AbdAJQ65 (ORCPT ); Tue, 10 Jan 2017 11:58:57 -0500 Date: Tue, 10 Jan 2017 17:59:18 +0100 From: Greg Kroah-Hartman To: Holger Dengler Cc: Arnd Bergmann , Lee Jones , Vinod Koul , linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, Thomas Gleixner , Sebastian Siewior , Juergen Bubeck , Peter Mahler , Benedikt Spranger Subject: Re: [PATCH 08/12] misc: Flexcard misc device support Message-ID: <20170110165918.GB19767@kroah.com> References: <1481674313-30378-1-git-send-email-dengler@linutronix.de> <1481674313-30378-9-git-send-email-dengler@linutronix.de> <2743725.AuCyd3B69p@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 14, 2016 at 10:28:25AM +0100, Holger Dengler wrote: > On 12/14/2016 09:42 AM, Arnd Bergmann wrote: > > On Wednesday, December 14, 2016 1:11:49 AM CET Holger Dengler wrote: > >> The Flexcard PCI BAR0 contain registers for configuration but also > >> for informational purpose like error counter, statistical information > >> and some timestamps. The read-only mmap of the misc device offers the > >> userspace a fast access to these registers. > >> > >> Signed-off-by: Benedikt Spranger > >> Signed-off-by: Holger Dengler > >> cc: Arnd Bergmann > >> cc: Greg Kroah-Hartman > >> --- > >> drivers/mfd/Kconfig | 1 + > >> drivers/misc/Kconfig | 6 ++ > >> drivers/misc/Makefile | 1 + > >> drivers/misc/flexcard_misc.c | 165 +++++++++++++++++++++++++++++++++++++++++++ > >> 4 files changed, 173 insertions(+) > >> create mode 100644 drivers/misc/flexcard_misc.c > >> > > > > Maybe this could fit better in drivers/uio/ than drivers/misc? It > > seems to only export a memory mapped device. > > You're right, this patch only introduce the memory mapping. But the > next patch in series add also some attributes to the device, therfore > we put it in drivers/misc. That's fine, it should still be a uio driver as that's what it does. You can have sysfs files for a UIO device, right? thanks, greg k-h