From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941134AbdAJRhv (ORCPT ); Tue, 10 Jan 2017 12:37:51 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:39300 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S937378AbdAJRhV (ORCPT ); Tue, 10 Jan 2017 12:37:21 -0500 Date: Tue, 10 Jan 2017 18:37:36 +0100 From: Greg KH To: Corentin Labbe Cc: willy@haproxy.com, ksenija.stanojevic@gmail.com, arnd@arndb.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH] misc: panel: move LCD_MINOR and KEYPAD_MINOR to include/linux/miscdevice.h Message-ID: <20170110173736.GB1340@kroah.com> References: <20161215194352.9729-1-clabbe.montjoie@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161215194352.9729-1-clabbe.montjoie@gmail.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 15, 2016 at 08:43:52PM +0100, Corentin Labbe wrote: > This patch move the define for LCD_MINOR and KEYPAD_MINOR to include/linux/miscdevice.h. > It's better that all minor number definitions are in the same place. > > Signed-off-by: Corentin Labbe > --- > drivers/misc/panel.c | 3 --- > include/linux/miscdevice.h | 2 ++ > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/misc/panel.c b/drivers/misc/panel.c > index 6030ac5..b05c3c7 100644 > --- a/drivers/misc/panel.c > +++ b/drivers/misc/panel.c > @@ -61,9 +61,6 @@ > #include > #include > > -#define LCD_MINOR 156 > -#define KEYPAD_MINOR 185 > - > #define PANEL_VERSION "0.9.5" > > #define LCD_MAXBYTES 256 /* max burst write */ > diff --git a/include/linux/miscdevice.h b/include/linux/miscdevice.h > index b1ba37aef..7efc045 100644 > --- a/include/linux/miscdevice.h > +++ b/include/linux/miscdevice.h > @@ -30,9 +30,11 @@ > #define NVRAM_MINOR 144 > #define SGI_MMTIMER 153 > #define STORE_QUEUE_MINOR 155 /* unused */ > +#define LCD_MINOR 156 > #define I2O_MINOR 166 > #define HWRNG_MINOR 183 > #define MICROCODE_MINOR 184 > +#define KEYPAD_MINOR 185 > #define D7S_MINOR 193 > #define VFIO_MINOR 196 > #define TUN_MINOR 200 Doesn't apply to my tree :(