From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754149AbdAJVmW (ORCPT <rfc822;w@1wt.eu>);
        Tue, 10 Jan 2017 16:42:22 -0500
Received: from mx1.redhat.com ([209.132.183.28]:45864 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752620AbdAJVmT (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 10 Jan 2017 16:42:19 -0500
Date: Tue, 10 Jan 2017 15:42:07 -0600
From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>, Ingo Molnar <mingo@redhat.com>,
        linux-kernel@vger.kernel.org,
        Ananth N Mavinakayanahalli <ananth@linux.vnet.ibm.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        "H . Peter Anvin" <hpa@zytor.com>,
        Andrey Konovalov <andreyknvl@google.com>,
        Andy Lutomirski <luto@kernel.org>
Subject: Re: [PATCH tip/master v4] kprobes: extable: Identify kprobes'
 insn-slots as kernel text area
Message-ID: <20170110214207.dd52me5mtz6hhuzb@treble>
References: <20170104100102.GE25813@worktop.programming.kicks-ass.net>
 <148388747896.6869.6354262871751682264.stgit@devbox>
 <20170109173648.k7dxu7nz22qc6upq@treble>
 <20170110085923.GD3092@twins.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20170110085923.GD3092@twins.programming.kicks-ass.net>
User-Agent: Mutt/1.6.0.1 (2016-04-01)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Tue, 10 Jan 2017 21:42:09 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jan 10, 2017 at 09:59:23AM +0100, Peter Zijlstra wrote:
> On Mon, Jan 09, 2017 at 11:36:48AM -0600, Josh Poimboeuf wrote:
> > BTW, I think we'll have more problems with generated code if/when we
> > move to an x86 DWARF unwinder, because it won't have any idea how to
> > unwind past generated code.  Long term I wonder if it would make sense
> > to create some kind of framework for creating or registering generated
> > code, so we can solve these types of problems in a single place.
> 
> Yes, this seems like a good idea. Maybe we could pull the rbtree thing
> from modules and make that a more generic interface for code
> registration.

Yeah, a generic fast lookup for module+generated code could be useful.
It would also be nice to associate names with generated functions and
integrate that with kallsyms.  For DWARF we would also need a way to
associate CFI metadata with address ranges.

-- 
Josh