From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759088AbdAKAOc (ORCPT ); Tue, 10 Jan 2017 19:14:32 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:44913 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756496AbdAKAOa (ORCPT ); Tue, 10 Jan 2017 19:14:30 -0500 Date: Wed, 11 Jan 2017 01:14:19 +0100 From: Alexandre Belloni To: Bhumika Goyal Cc: julia.lawall@lip6.fr, a.zummo@towertech.it, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rtc: constify rtc_class_ops structures Message-ID: <20170111001419.vefa3knfkynnmflr@piout.net> References: <1483635305-20423-1-git-send-email-bhumirks@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1483635305-20423-1-git-send-email-bhumirks@gmail.com> User-Agent: NeoMutt/20161126 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/01/2017 at 22:25:05 +0530, Bhumika Goyal wrote : > Declare rtc_class_ops structures as const as they are only passed > as an argument to the function devm_rtc_device_register. This argument > is of type const struct rtc_class_ops *, so rtc_class_ops structures > having this property can be declared const. > Done using Coccinelle: > > @r1 disable optional_qualifier @ > identifier i; > position p; > @@ > static struct rtc_class_ops i@p = {...}; > > @ok1@ > identifier r1.i; > position p; > @@ > devm_rtc_device_register(...,&i@p,...) > > @bad@ > position p!={r1.p,ok1.p}; > identifier r1.i; > @@ > i@p > > @depends on !bad disable optional_qualifier@ > identifier r1.i; > @@ > +const > struct rtc_class_ops i; > > File size details: > > text data bss dec hex filename > 559 320 0 879 36f drivers/rtc/rtc-dm355evm.o > 671 192 0 863 35f drivers/rtc/rtc-dm355evm.o > > 4727 320 0 5047 13b7 drivers/rtc/rtc-imxdi.o > 4855 192 0 5047 13b7 drivers/rtc/rtc-imxdi.o > > 1269 192 0 1461 5b5 drivers/rtc/rtc-mxc.o > > File size remains unchanged for : drivers/rtc/rtc-mxc.o > > Signed-off-by: Bhumika Goyal > --- > drivers/rtc/rtc-dm355evm.c | 2 +- > drivers/rtc/rtc-imxdi.c | 2 +- > drivers/rtc/rtc-mxc.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com