From: Stafford Horne <shorne@gmail.com>
To: Darren Hart <dvhart@infradead.org>
Cc: Shuah Khan <shuah@kernel.org>,
linux-kernel@vger.kernel.org, dvhart@linux.intel.com,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH] selftests/futex: Fix makefile dependencies
Date: Wed, 11 Jan 2017 17:48:51 +0900 [thread overview]
Message-ID: <20170111084851.GB25986@lianli.shorne-pla.net> (raw)
In-Reply-To: <20170111080755.GA36664@f23x64.localdomain>
On Wed, Jan 11, 2017 at 12:07:55AM -0800, Darren Hart wrote:
> On Wed, Jan 11, 2017 at 01:37:19PM +0900, Stafford Horne wrote:
> > On Tue, Jan 10, 2017 at 02:17:18PM -0800, Darren Hart wrote:
> > > On Tue, Jan 10, 2017 at 02:10:42PM -0800, Darren Hart wrote:
> > > > On Fri, Jan 06, 2017 at 01:18:39PM +0900, Stafford Horne wrote:
> > > > > I am working on doing selftests for openrisc and found issues with the
> > > > > futex test is not building after changes to the tests source.
> > > > >
> > > > > This issue is that the TARGETS variable used in the futex Makefile is
> > > > > also used by the selftests Makefile, so when building from toplevel the
> > > > > TARGETS variable is clobbered and nothing gets built. Changed the
> > > > > variable name to get around that.
> > > > >
> > > > > Also, the futex makefile did not contain dependencies for all headers,
> > > > > so if we make changes to logging.h rebuild will not happen. Add headers
> > > > > to fix it up.
> > > > >
> > > > > Signed-off-by: Stafford Horne <shorne@gmail.com>
> > > >
> > > > Thanks for catching this and the fix.
> > > >
> > > > +Shuah Khan
> > > >
> > > > Note: This appears also to be a problem for intel_pstate/Makefile
> > >
> > > Or, it would be if intel_pstate was listed in selftests/Makefile :-)
> >
> > Right, thanks for having a look. I actually have a small patch to also
> > add <stdio.h> to logging.h. If you have not already fixed the
> > intel_pstate test I'll send them all together.
>
> Please do, thanks!
Hello,
Actually I just had a look at Shuah's linux-kselftest repo on
kernel.org. It looks like Bamvor Jian has actually fixed a lot of these
issues on the next branch.
I will see what is missing if anything.
-Stafford
next prev parent reply other threads:[~2017-01-11 8:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-06 4:18 [PATCH] selftests/futex: Fix makefile dependencies Stafford Horne
2017-01-10 22:10 ` Darren Hart
2017-01-10 22:17 ` Darren Hart
2017-01-11 4:37 ` Stafford Horne
2017-01-11 8:07 ` Darren Hart
2017-01-11 8:48 ` Stafford Horne [this message]
2017-01-11 14:41 ` Shuah Khan
2017-01-11 15:29 ` Stafford Horne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170111084851.GB25986@lianli.shorne-pla.net \
--to=shorne@gmail.com \
--cc=dvhart@infradead.org \
--cc=dvhart@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).