From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Paul Menzel <pmenzel@molgen.mpg.de>
Cc: Jan Niehusmann <jan@gondor.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Thorsten Leemhuis <linux@leemhuis.info>,
Daniel Blueman <daniel@quora.org>,
Len Brown <len.brown@intel.com>,
Tomas Winkler <tomas.winkler@intel.com>,
Alexander Usyskin <alexander.usyskin@intel.com>
Subject: Re: Dell XPS13 does not suspend with Linux 4.10-rc3
Date: Wed, 11 Jan 2017 10:36:22 +0100 [thread overview]
Message-ID: <20170111093622.GA16662@kroah.com> (raw)
In-Reply-To: <384df4ea-8a3e-0db3-c057-e8ef46912504@molgen.mpg.de>
On Wed, Jan 11, 2017 at 09:53:38AM +0100, Paul Menzel wrote:
> Dear Linux folks,
>
>
> On 01/10/17 23:24, Jan Niehusmann wrote:
> > On Tue, Jan 10, 2017 at 09:43:31PM +0100, Jan Niehusmann wrote:
> > > And I bisected the issue to commit 7279b238ba, "mei: send OS type to the
> > > FW"
> >
> > Indeed, just disabling the FIXUP implemented by that commit fixes
> > suspend for me, with 4.10.0-rc3. Btw, this is on a Thinkpad x201s.
> >
> > (For the addressees newly added to cc, it seems like the mentioned
> > commit breaks suspend to ram on Dell XPS13 and Thinkpad x201s)
> >
> > --- a/drivers/misc/mei/bus-fixup.c
> > +++ b/drivers/misc/mei/bus-fixup.c
> > @@ -406,3 +406,3 @@ static struct mei_fixup {
> > MEI_FIXUP(MEI_UUID_WD, mei_wd),
> > - MEI_FIXUP(MEI_UUID_MKHIF_FIX, mei_mkhi_fix),
> > +// MEI_FIXUP(MEI_UUID_MKHIF_FIX, mei_mkhi_fix),
> > };
> >
> >
> > I don't know what this may break, as the description of 7279b23 just
> > says:
> > "This workaround was added to support other broken OS and we need to
> > follow here."
> >
> > Unless there is a better justification, I think the commit should be
> > reverted, for now.
>
> Somebody else already created the bug 192051 in the Linux Kernel Bug Tracker
> [1].
There's a fix for this in my tree to go to Linus for 4.10-rc4.
thanks,
greg k-h
next prev parent reply other threads:[~2017-01-11 9:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-10 14:08 Dell XPS13 does not suspend with Linux 4.10-rc3 Paul Menzel
2017-01-10 14:21 ` Thorsten Leemhuis
2017-01-10 20:43 ` Jan Niehusmann
2017-01-10 22:24 ` Jan Niehusmann
2017-01-11 8:53 ` Paul Menzel
2017-01-11 9:36 ` Greg Kroah-Hartman [this message]
2017-01-11 9:41 ` Paul Menzel
2017-01-11 9:49 ` Winkler, Tomas
2017-01-11 17:16 ` Paul Menzel
2017-01-11 22:14 ` Winkler, Tomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170111093622.GA16662@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alexander.usyskin@intel.com \
--cc=daniel@quora.org \
--cc=jan@gondor.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@leemhuis.info \
--cc=pmenzel@molgen.mpg.de \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).