From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965725AbdAKL7P (ORCPT ); Wed, 11 Jan 2017 06:59:15 -0500 Received: from server.atrad.com.au ([150.101.241.2]:34498 "EHLO server.atrad.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935026AbdAKL7M (ORCPT ); Wed, 11 Jan 2017 06:59:12 -0500 Date: Wed, 11 Jan 2017 22:28:20 +1030 From: Jonathan Woithe To: Micha?? K??pie?? Cc: Darren Hart , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/4] fujitsu-laptop: acpi_fujitsu_hotkey_notify() cleanup Message-ID: <20170111115820.GF17476@marvin.atrad.com.au> References: <20170111085933.2486-1-kernel@kempniu.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170111085933.2486-1-kernel@kempniu.pl> User-Agent: Mutt/1.5.23 (2014-03-12) X-MIMEDefang-action: accept Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 11, 2017 at 09:59:29AM +0100, Micha?? K??pie?? wrote: > I am currently preparing a patch series which makes fujitsu-laptop use a > sparse keymap for hotkey handling. Before that will happen, though, > acpi_fujitsu_hotkey_notify() could use a revamp because it is pretty > hard to read as it is. To avoid posting everything at once, here are a > few patches which IMHO make that function easier to read. Some of these > changes might be a matter of taste, so feel free to NACK them or suggest > a preferred alternative. This patch series provides a significant clean up to the functions it focuses on. As such I have no real objections to them. However, because my Fujitsu laptop doesn't have any of the hotkeys of later models I am unable to test these patches with real hardware. Have you been able to do so? If they have been verified I have no problem acking these. Otherwise I will have to do as much as I can (given no access to relevant hardware) to ensure the overall behaviour isn't changed. Regards jonathan