From: Alex Williamson <alex.williamson@redhat.com>
To: Jike Song <jike.song@intel.com>
Cc: serge@hallyn.com, linux-security-module@vger.kernel.org,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
kwankhede@nvidia.com, kraxel@redhat.com
Subject: Re: [PATCH 1/2] capability: export has_capability
Date: Wed, 11 Jan 2017 13:47:01 -0500 [thread overview]
Message-ID: <20170111134701.7d153d34@t450s.home> (raw)
In-Reply-To: <1482336616-19252-2-git-send-email-jike.song@intel.com>
On Thu, 22 Dec 2016 00:10:15 +0800
Jike Song <jike.song@intel.com> wrote:
> has_capability() is sometimes needed by modules to test capability
> for specified task other than current, so export it.
>
> Cc: Alex Williamson <alex.williamson@redhat.com>
> Cc: Kirti Wankhede <kwankhede@nvidia.com>
> Signed-off-by: Jike Song <jike.song@intel.com>
> ---
> kernel/capability.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/capability.c b/kernel/capability.c
> index 4984e1f..e2e198c 100644
> --- a/kernel/capability.c
> +++ b/kernel/capability.c
> @@ -318,6 +318,7 @@ bool has_capability(struct task_struct *t, int cap)
> {
> return has_ns_capability(t, &init_user_ns, cap);
> }
> +EXPORT_SYMBOL(has_capability);
>
> /**
> * has_ns_capability_noaudit - Does a task have a capability (unaudited)
Are we using EXPORT_SYMBOL vs EXPORT_SYMBOL_GPL here to match the other
exports in this file? We could use _GPL to match the expected caller
of this.
Serge,
Do you have any comments on this patch? I'd be happy to pull it
through the vfio tree with an appropriate Ack. Thanks,
Alex
next prev parent reply other threads:[~2017-01-11 18:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-21 16:10 [PATCH 0/2] test capability for remote task Jike Song
2016-12-21 16:10 ` [PATCH 1/2] capability: export has_capability Jike Song
2017-01-11 18:47 ` Alex Williamson [this message]
2017-01-12 0:56 ` Jike Song
2017-01-12 6:45 ` Serge E. Hallyn
2016-12-21 16:10 ` [PATCH 2/2] vfio iommu type1: fix the testing of capability for remote task Jike Song
2016-12-22 12:20 ` Kirti Wankhede
2016-12-23 2:36 ` Jike Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170111134701.7d153d34@t450s.home \
--to=alex.williamson@redhat.com \
--cc=jike.song@intel.com \
--cc=kraxel@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).