From: David Sterba <dsterba@suse.cz>
To: Michal Hocko <mhocko@kernel.org>
Cc: Chris Mason <clm@fb.com>, David Sterba <dsterba@suse.com>,
Josef Bacik <jbacik@fb.com>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH 2/2] btrfs: drop gfp mask tweaking in try_release_extent_state
Date: Wed, 11 Jan 2017 17:03:48 +0100 [thread overview]
Message-ID: <20170111160348.GK12081@twin.jikos.cz> (raw)
In-Reply-To: <20170109143903.32280-2-mhocko@kernel.org>
On Mon, Jan 09, 2017 at 03:39:03PM +0100, Michal Hocko wrote:
> From: Michal Hocko <mhocko@suse.com>
>
> try_release_extent_state reduces the gfp mask to GFP_NOFS if it is
> compatible. This is true for GFP_KERNEL as well. There is no real
> reason to do that though. There is no new lock taken down the
> the only consumer of the gfp mask which is
> try_release_extent_state
> clear_extent_bit
> __clear_extent_bit
> alloc_extent_state
>
> So this seems just unnecessary and confusing.
>
> Signed-off-by: Michal Hocko <mhocko@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
next prev parent reply other threads:[~2017-01-11 16:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-09 14:39 [PATCH 1/2] etrfs: fix up misleading GFP_NOFS usage in btrfs_releasepage Michal Hocko
2017-01-09 14:39 ` [PATCH 2/2] btrfs: drop gfp mask tweaking in try_release_extent_state Michal Hocko
2017-01-11 16:03 ` David Sterba [this message]
2017-01-11 13:55 ` [PATCH 1/2] etrfs: fix up misleading GFP_NOFS usage in btrfs_releasepage David Sterba
2017-01-11 16:16 ` Michal Hocko
2017-01-11 16:18 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170111160348.GK12081@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=jbacik@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@kernel.org \
--cc=mhocko@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).