From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1031180AbdAKSh3 (ORCPT <rfc822;w@1wt.eu>);
        Wed, 11 Jan 2017 13:37:29 -0500
Received: from mx1.redhat.com ([209.132.183.28]:53971 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752806AbdAKSh0 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 11 Jan 2017 13:37:26 -0500
Date: Wed, 11 Jan 2017 19:37:23 +0100
From: Jiri Olsa <jolsa@redhat.com>
To: Willy Tarreau <w@1wt.eu>
Cc: Andi Kleen <andi@firstfloor.org>, acme@kernel.org, jolsa@kernel.org,
        mingo@kernel.org, linux-kernel@vger.kernel.org,
        Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 1/5] perf, tools: Add probing for xed
Message-ID: <20170111183723.GC29004@krava>
References: <20170110010225.24870-1-andi@firstfloor.org>
 <20170110010225.24870-2-andi@firstfloor.org>
 <20170110061150.GB4450@1wt.eu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170110061150.GB4450@1wt.eu>
User-Agent: Mutt/1.7.1 (2016-10-04)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Wed, 11 Jan 2017 18:37:27 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jan 10, 2017 at 07:11:50AM +0100, Willy Tarreau wrote:
> Hi Andi,
> 
> just a very minor cosmetic detail, but your editor seems to use tabs while
> there were 8 spaces around, causing visual alignment defects below :
> 
> On Mon, Jan 09, 2017 at 05:02:21PM -0800, Andi Kleen wrote:
> > diff --git a/tools/build/Makefile.feature b/tools/build/Makefile.feature
> > index e3fb5ecbdcb6..971a9ef87ca6 100644
> > --- a/tools/build/Makefile.feature
> > +++ b/tools/build/Makefile.feature
> > @@ -63,7 +63,7 @@ FEATURE_TESTS_BASIC :=                  \
> >          lzma                            \
> >          get_cpuid                       \
> >          bpf                             \
> > -        sdt
> > +	sdt				\
> 
> here
> 
> >  # FEATURE_TESTS_BASIC + FEATURE_TESTS_EXTRA is the complete list
> >  # of all feature tests
> > @@ -74,11 +74,12 @@ FEATURE_TESTS_EXTRA :=                  \
> >           cplus-demangle                 \
> >           hello                          \
> >           libbabeltrace                  \
> > +	 xed				\
> 
> here
> 
> >           liberty                        \
> >           liberty-z                      \
> >           libunwind-debug-frame          \
> >           libunwind-debug-frame-arm      \
> > -         libunwind-debug-frame-aarch64
> > +	 libunwind-debug-frame-aarch64
> 
> here
> 
> >  
> >  FEATURE_TESTS ?= $(FEATURE_TESTS_BASIC)
> >  
> > @@ -105,7 +106,7 @@ FEATURE_DISPLAY ?=              \
> >           zlib                   \
> >           lzma                   \
> >           get_cpuid              \
> > -         bpf
> > +	 bpf
> 
> and here.
> 
> I think it would be nice to fix them before merging.
> 
> Did I say it was very minor ? :-)

yea, but still.. ;-)

jirka