From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752470AbdAKUe5 (ORCPT ); Wed, 11 Jan 2017 15:34:57 -0500 Received: from fllnx209.ext.ti.com ([198.47.19.16]:57323 "EHLO fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750864AbdAKUez (ORCPT ); Wed, 11 Jan 2017 15:34:55 -0500 Date: Wed, 11 Jan 2017 14:33:26 -0600 From: Bin Liu To: Icenowy Zheng CC: Maxime Ripard , Chen-Yu Tsai , Kishon Vijay Abraham I , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" Subject: Re: [PATCH 4/4] ARM: dts: sun8i: add OTG function to Lichee Pi Zero Message-ID: <20170111203326.GB16865@uda0271908> Mail-Followup-To: Bin Liu , Icenowy Zheng , Maxime Ripard , Chen-Yu Tsai , Kishon Vijay Abraham I , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" References: <20170103152534.20118-1-icenowy@aosc.xyz> <20170103152534.20118-5-icenowy@aosc.xyz> <20170110202443.GC2479@uda0271908> <2733831484164533@web1g.yandex.ru> <20170111200811.GA16865@uda0271908> <418251484165614@web21h.yandex.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <418251484165614@web21h.yandex.ru> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 12, 2017 at 04:13:34AM +0800, Icenowy Zheng wrote: > > > 12.01.2017, 04:08, "Bin Liu" : > > On Thu, Jan 12, 2017 at 03:55:33AM +0800, Icenowy Zheng wrote: > >>  11.01.2017, 04:24, "Bin Liu" : > >>  > On Tue, Jan 03, 2017 at 11:25:34PM +0800, Icenowy Zheng wrote: > >>  >>  Lichee Pi Zero features a USB OTG port. > >>  >> > >>  >>  Add support for it. > >>  >> > >>  >>  Note: in order to use the Host mode, the board must be powered via the > >>  >>  +5V and GND pins. > >>  >> > >>  >>  Signed-off-by: Icenowy Zheng > >>  >>  --- > >>  >>   arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dts | 10 ++++++++++ > >>  >>   1 file changed, 10 insertions(+) > >>  >> > >>  >>  diff --git a/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dts b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dts > >>  >>  index 0099affc6ce3..3d9168cbaeca 100644 > >>  >>  --- a/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dts > >>  >>  +++ b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dts > >>  >>  @@ -71,3 +71,13 @@ > >>  >>           pinctrl-names = "default"; > >>  >>           status = "okay"; > >>  >>   }; > >>  >>  + > >>  >>  +&usb_otg { > >>  >>  + dr_mode = "otg"; > >>  > > >>  > Why not set this default mode in dtsi instead? > >>  > > >>  > Regards, > >>  > -Bin. > >> > >>  There's possibly boards which do not have OTG functions. > > > > That is board specific. > > > > You'd better to define the default dr_mode which the musb _controller_ > > supports in the dtsi, and then override it in a specific board dts if > > necessary. > > Is there MUSB controllers which do not support a certain mode? I am not aware of any. That is why I recommended to set "otg" in dtsi, then override it in board dts if a port is specically designed to host-only or device-only mode. > > (I remembered my omap3-n900 which do not work under OTG mode...) I belive it is n900 board specific. omap3 itself doesn't have such limitation, AFAIK. Regards, -Bin. > > > > > Regards, > > -Bin. > > > >>  Even the official CDR design of V3s uses the USB controller to > >>  connect a UVC webcam to make the design a dual-cam design > >>  (V3s itself has a CSI). > >> > >>  > > >>  >>  + status = "okay"; > >>  >>  +}; > >>  >>  + > >>  >>  +&usbphy { > >>  >>  + usb0_id_det-gpio = <&pio 5 6 GPIO_ACTIVE_HIGH>; > >>  >>  + status = "okay"; > >>  >>  +}; > >>  >>  -- > >>  >>  2.11.0