From: Bjorn Helgaas <helgaas@kernel.org>
To: Rahul Krishnan <mrahul.krishnan@gmail.com>
Cc: benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au,
bhelgaas@google.com, linuxppc-dev@lists.ozlabs.org,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] pci: hotplug: This patch removes unnecessary return statement using spatch tool
Date: Wed, 11 Jan 2017 14:55:14 -0600 [thread overview]
Message-ID: <20170111205514.GI14532@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <20161224093800.GA24893@rahul>
On Sat, Dec 24, 2016 at 03:08:00PM +0530, Rahul Krishnan wrote:
>
> This patch removes unnecessary return statement using spatch tool
>
> Signed-off-by: Rahul Krishnan <mrahul.krishnan@gmail.com>
Applied to pci/hotplug for v4.11 with Tyrel's Reviewed-by, thanks!
Are there other similar instances elsewhere in drivers/pci? If so,
can you fix them all at once?
> ---
> drivers/pci/hotplug/rpadlpar_core.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/pci/hotplug/rpadlpar_core.c b/drivers/pci/hotplug/rpadlpar_core.c
> index dc67f39..78ce2c7 100644
> --- a/drivers/pci/hotplug/rpadlpar_core.c
> +++ b/drivers/pci/hotplug/rpadlpar_core.c
> @@ -455,7 +455,6 @@ static inline int is_dlpar_capable(void)
>
> int __init rpadlpar_io_init(void)
> {
> - int rc = 0;
>
> if (!is_dlpar_capable()) {
> printk(KERN_WARNING "%s: partition not DLPAR capable\n",
> @@ -463,8 +462,7 @@ int __init rpadlpar_io_init(void)
> return -EPERM;
> }
>
> - rc = dlpar_sysfs_init();
> - return rc;
> + return dlpar_sysfs_init();
> }
>
> void rpadlpar_io_exit(void)
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2017-01-11 20:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-24 9:38 [PATCH v2] pci: hotplug: This patch removes unnecessary return statement using spatch tool Rahul Krishnan
2016-12-27 22:33 ` Tyrel Datwyler
2017-01-11 20:55 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170111205514.GI14532@bhelgaas-glaptop.roam.corp.google.com \
--to=helgaas@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=mrahul.krishnan@gmail.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).