From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750796AbdALGpf (ORCPT ); Thu, 12 Jan 2017 01:45:35 -0500 Received: from h2.hallyn.com ([78.46.35.8]:55950 "EHLO h2.hallyn.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750698AbdALGpd (ORCPT ); Thu, 12 Jan 2017 01:45:33 -0500 Date: Thu, 12 Jan 2017 00:45:32 -0600 From: "Serge E. Hallyn" To: Alex Williamson Cc: Jike Song , serge@hallyn.com, linux-security-module@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, kwankhede@nvidia.com, kraxel@redhat.com Subject: Re: [PATCH 1/2] capability: export has_capability Message-ID: <20170112064531.GA8577@mail.hallyn.com> References: <1482336616-19252-1-git-send-email-jike.song@intel.com> <1482336616-19252-2-git-send-email-jike.song@intel.com> <20170111134701.7d153d34@t450s.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170111134701.7d153d34@t450s.home> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 11, 2017 at 01:47:01PM -0500, Alex Williamson wrote: > On Thu, 22 Dec 2016 00:10:15 +0800 > Jike Song wrote: > > > has_capability() is sometimes needed by modules to test capability > > for specified task other than current, so export it. > > > > Cc: Alex Williamson > > Cc: Kirti Wankhede > > Signed-off-by: Jike Song > > --- > > kernel/capability.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/kernel/capability.c b/kernel/capability.c > > index 4984e1f..e2e198c 100644 > > --- a/kernel/capability.c > > +++ b/kernel/capability.c > > @@ -318,6 +318,7 @@ bool has_capability(struct task_struct *t, int cap) > > { > > return has_ns_capability(t, &init_user_ns, cap); > > } > > +EXPORT_SYMBOL(has_capability); > > > > /** > > * has_ns_capability_noaudit - Does a task have a capability (unaudited) > > Are we using EXPORT_SYMBOL vs EXPORT_SYMBOL_GPL here to match the other > exports in this file? We could use _GPL to match the expected caller > of this. > > > Serge, > > Do you have any comments on this patch? I'd be happy to pull it > through the vfio tree with an appropriate Ack. Thanks, Sure, thanks, looks good to me. Acked-by: Serge Hallyn