From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751227AbdALIw5 (ORCPT <rfc822;w@1wt.eu>);
        Thu, 12 Jan 2017 03:52:57 -0500
Received: from mx1.redhat.com ([209.132.183.28]:55702 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750807AbdALIw4 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 12 Jan 2017 03:52:56 -0500
Date: Thu, 12 Jan 2017 09:52:53 +0100
From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <ak@linux.intel.com>
Cc: Andi Kleen <andi@firstfloor.org>, acme@kernel.org, jolsa@kernel.org,
        mingo@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] perf, tools: Add probing for xed
Message-ID: <20170112085253.GA31701@krava>
References: <20170110010225.24870-1-andi@firstfloor.org>
 <20170110010225.24870-2-andi@firstfloor.org>
 <20170111183714.GB29004@krava>
 <20170111221756.GG8388@tassilo.jf.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170111221756.GG8388@tassilo.jf.intel.com>
User-Agent: Mutt/1.7.1 (2016-10-04)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 12 Jan 2017 08:52:56 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jan 11, 2017 at 02:17:56PM -0800, Andi Kleen wrote:
> > > diff --git a/tools/build/Makefile.feature b/tools/build/Makefile.feature
> > > index e3fb5ecbdcb6..971a9ef87ca6 100644
> > > --- a/tools/build/Makefile.feature
> > > +++ b/tools/build/Makefile.feature
> > > @@ -63,7 +63,7 @@ FEATURE_TESTS_BASIC :=                  \
> > >          lzma                            \
> > >          get_cpuid                       \
> > >          bpf                             \
> > > -        sdt
> > > +	sdt				\
> > 
> > looks like you forgot to add xed in here? why the '\' ?
> 
> I removed it, but incompletely.
> 
> > anyway, please add it in here so it's visible under make VF=1
> 
> If I add it here then it is shown by default (even without VF=1).
> Arnaldo requested earlier that it shouldn't be shown.

if you put it to FEATURE_TESTS_BASIC then it's displayed only for VF=1

FEATURE_DISPLAY is the one that's displayed by default

jirka