From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751476AbdALLrW (ORCPT ); Thu, 12 Jan 2017 06:47:22 -0500 Received: from guitar.tcltek.co.il ([192.115.133.116]:55695 "EHLO mx.tkos.co.il" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750903AbdALLrU (ORCPT ); Thu, 12 Jan 2017 06:47:20 -0500 Date: Thu, 12 Jan 2017 13:47:09 +0200 From: Baruch Siach To: Guenter Roeck Cc: Wim Van Sebroeck , linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 16/62] watchdog: digicolor_wdt: Convert to use device managed functions and other improvements Message-ID: <20170112114708.3d4chjtu3fibb7px@tarshish> References: <1484091325-9199-1-git-send-email-linux@roeck-us.net> <1484091325-9199-17-git-send-email-linux@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1484091325-9199-17-git-send-email-linux@roeck-us.net> User-Agent: NeoMutt/20161126 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Guenter, On Tue, Jan 10, 2017 at 03:34:33PM -0800, Guenter Roeck wrote: > Use device managed functions to simplify error handling, reduce > source code size, improve readability, and reduce the likelyhood of bugs. > Other improvements as listed below. > > The conversion was done automatically with coccinelle using the > following semantic patches. The semantic patches and the scripts used > to generate this commit log are available at > https://github.com/groeck/coccinelle-patches > > - Replace 'goto l; ... l: return e;' with 'return e;' > - Replace 'val = e; return val;' with 'return e;' > - Drop assignments to otherwise unused variables > - Replace 'if (e) { return expr; }' with 'if (e) return expr;' > - Drop remove function > - Replace of_iomap() with platform_get_resource() followed by > devm_ioremap_resource() > - Drop platform_set_drvdata() > - Replace &pdev->dev with dev if 'struct device *dev' is a declared > variable > - Use devm_watchdog_register_driver() to register watchdog device > - Replace shutdown function with call to watchdog_stop_on_reboot() > > Cc: Baruch Siach > Signed-off-by: Guenter Roeck Acked-by: Baruch Siach Tested-by: Baruch Siach Thanks, baruch -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -