From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751009AbdALWiR (ORCPT ); Thu, 12 Jan 2017 17:38:17 -0500 Received: from mail.fireflyinternet.com ([109.228.58.192]:57259 "EHLO fireflyinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750824AbdALWiQ (ORCPT ); Thu, 12 Jan 2017 17:38:16 -0500 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Date: Thu, 12 Jan 2017 22:38:07 +0000 From: Chris Wilson To: lkml@pengaru.com Cc: linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, "# v4 . 10-rc1+" Subject: Re: [PATCH v2] drm/i915: Flush untouched framebuffers before display on !llc Message-ID: <20170112223807.GA3985@nuc-i3427.alporthouse.com> Mail-Followup-To: Chris Wilson , lkml@pengaru.com, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, "# v4 . 10-rc1+" References: <20170109063240.GB9125@shells.gnugeneration.com> <20170109111932.6342-1-chris@chris-wilson.co.uk> <20170112211706.GC28328@nuc-i3427.alporthouse.com> <20170112222450.GE32751@shells.gnugeneration.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170112222450.GE32751@shells.gnugeneration.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 12, 2017 at 04:24:50PM -0600, lkml@pengaru.com wrote: > On Thu, Jan 12, 2017 at 09:17:06PM +0000, Chris Wilson wrote: > > On Mon, Jan 09, 2017 at 11:19:32AM +0000, Chris Wilson wrote: > > > On a non-llc system, the objects are created with .cache_level = > > > CACHE_NONE and so the transition to uncached for scanout is a no-op. > > > However, if the object was never written to, it will still be in the CPU > > > domain (having been zeroed out by shmemfs). Those cachelines need to be > > > flushed prior to display. > > > > > > Reported-by: Vito Caputo > > > Fixes: a6a7cc4b7db6 ("drm/i915: Always flush the dirty CPU cache when pinning the scanout") > > > Signed-off-by: Chris Wilson > > > Cc: # v4.10-rc1+ > > > > Ping? > > This patch fixes the problem for me, in case that's what the ping's for. Partly that, and trying to catch CI + reviewers. > Out of curiosity the bug I reported described here be getting fixed in 4.10? > https://lists.freedesktop.org/archives/dri-devel/2017-January/128405.html It was fixed in the tree back in December, bit of a muddle to get that particular patch into 4.10. -Chris -- Chris Wilson, Intel Open Source Technology Centre