From: Minchan Kim <minchan@kernel.org>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: <zhouxianrong@huawei.com>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>, <akpm@linux-foundation.org>,
<sergey.senozhatsky@gmail.com>, <ngupta@vflare.org>,
<Mi.Sophia.Wang@huawei.com>, <zhouxiyu@huawei.com>,
<weidu.du@huawei.com>, <zhangshiming5@huawei.com>,
<won.ho.park@huawei.com>
Subject: Re: [PATCH] mm: extend zero pages to same element pages for zram
Date: Fri, 13 Jan 2017 17:03:30 +0900 [thread overview]
Message-ID: <20170113080330.GB8018@bbox> (raw)
In-Reply-To: <20170113070245.GB484@jagdpanzerIV.localdomain>
On Fri, Jan 13, 2017 at 04:02:45PM +0900, Sergey Senozhatsky wrote:
> On (01/13/17 15:47), Minchan Kim wrote:
> [..]
> > > > Could you elaborate a bit? Do you mean this?
> > > >
> > > > ret = scnprintf(buf, PAGE_SIZE,
> > > > "%8llu %8llu %8llu %8lu %8ld %8llu %8lu\n",
> > > > orig_size << PAGE_SHIFT,
> > > > (u64)atomic64_read(&zram->stats.compr_data_size),
> > > > mem_used << PAGE_SHIFT,
> > > > zram->limit_pages << PAGE_SHIFT,
> > > > max_used << PAGE_SHIFT,
> > > > // (u64)atomic64_read(&zram->stats.zero_pages),
> > > > (u64)atomic64_read(&zram->stats.same_pages),
> > > > pool_stats.pages_compacted);
> > >
> > > yes, correct.
> > >
> > > do we need to export it as two different stats (zero_pages and
> > > same_pages), if those are basically same thing internally?
> >
> > So, let summary up.
> >
> > 1. replace zero_page stat into same page stat in mm_stat
> > 2. s/zero_pages/same_pages/Documentation/blockdev/zram.txt
> > 3. No need to warn to "cat /sys/block/zram0/mm_stat" user to see zero_pages
> > about semantic change
>
> 1) account zero_page and same_pages in one attr.
>
> this already is in the patch.
>
> 2) do not rename zero_pages attr.
>
> we can't do this so fast, I think.
>
>
> > 3. No need to warn to "cat /sys/block/zram0/mm_stat" user to see zero_pages
> > about semantic change
>
> yes. we just _may_ have more pages (depending on data pattern) which we treat
> as "zero" pages internally. this results in lower memory consumption. I don't
> think warn users about this change is necessary; they won't be able to do
> anything about it anyway. zero_pages stat is pretty much just a fun number to
> know. isn't it?
>
I just wanted to confirm your thought.
I hope anyone doesn't is sensitive on that number. ;)
Let's replace zero_page stat field in mm_stat.
Thanks.
next prev parent reply other threads:[~2017-01-13 8:07 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-06 8:42 [PATCH] mm: extend zero pages to same element pages for zram zhouxianrong
2017-01-09 23:41 ` Minchan Kim
2017-01-13 4:24 ` Sergey Senozhatsky
2017-01-13 6:23 ` Minchan Kim
2017-01-13 6:36 ` Sergey Senozhatsky
2017-01-13 6:47 ` Minchan Kim
2017-01-13 7:02 ` Sergey Senozhatsky
2017-01-13 8:03 ` Minchan Kim [this message]
2017-01-13 8:29 ` zhouxianrong
2017-01-21 8:43 ` Sergey Senozhatsky
2017-01-22 2:58 ` zhouxianrong
2017-01-22 4:45 ` Sergey Senozhatsky
2017-01-23 2:58 ` Joonsoo Kim
2017-01-23 3:32 ` zhouxianrong
2017-01-23 4:03 ` Sergey Senozhatsky
2017-01-23 6:27 ` Joonsoo Kim
2017-01-23 7:13 ` Sergey Senozhatsky
2017-01-23 7:40 ` Minchan Kim
2017-01-24 7:58 ` zhouxianrong
2017-01-25 1:29 ` Minchan Kim
2017-01-25 1:32 ` Sergey Senozhatsky
2017-01-25 2:48 ` Matthew Wilcox
2017-01-25 4:18 ` Sergey Senozhatsky
2017-01-25 4:51 ` Minchan Kim
2017-01-25 5:38 ` Sergey Senozhatsky
2017-01-25 5:44 ` Minchan Kim
2017-01-23 6:26 ` Matthew Wilcox
2017-01-23 6:32 ` 答复: " zhouxianrong
2017-02-03 8:34 ` zhouxianrong
2017-02-03 8:42 ` zhouxianrong
2017-02-03 15:33 ` Matthew Wilcox
2017-02-04 3:33 ` zhouxianrong
2017-02-05 14:21 ` Minchan Kim
2017-02-06 1:28 ` zhouxianrong
2017-02-06 14:14 ` Matthew Wilcox
2017-02-06 23:48 ` Minchan Kim
2017-02-07 2:20 ` zhouxianrong
2017-02-07 2:54 ` Minchan Kim
2017-02-07 3:24 ` zhouxianrong
2017-02-07 4:57 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170113080330.GB8018@bbox \
--to=minchan@kernel.org \
--cc=Mi.Sophia.Wang@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ngupta@vflare.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=weidu.du@huawei.com \
--cc=won.ho.park@huawei.com \
--cc=zhangshiming5@huawei.com \
--cc=zhouxianrong@huawei.com \
--cc=zhouxiyu@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).