From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752257AbdAMMF7 (ORCPT ); Fri, 13 Jan 2017 07:05:59 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:37784 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752490AbdAMMEu (ORCPT ); Fri, 13 Jan 2017 07:04:50 -0500 Date: Fri, 13 Jan 2017 12:04:08 +0000 From: Mark Brown To: Kevin Hilman Cc: David Lechner , nsekhar@ti.com, linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Message-ID: <20170113120408.3jtslvgifdpxchvp@sirena.org.uk> References: <1483673177-31516-1-git-send-email-david@lechnology.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="atb5t5jcis6a65ku" Content-Disposition: inline In-Reply-To: X-Cookie: To see you is to sympathize. User-Agent: NeoMutt/20161126 (1.7.1) X-SA-Exim-Connect-IP: 2001:470:1f1d:6b5::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [RESEND] spi: davinci: Allow device tree devices to use DMA X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --atb5t5jcis6a65ku Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jan 12, 2017 at 01:34:10PM -0800, Kevin Hilman wrote: > I thinks this driver needs an update to use spi_map_buf() to be able to > handle vmalloc'd buffers before always enabling DMA. Right. As I said elsewhere in the thread the driver looks like it needs some very serious TLC based on a quick scan through. --atb5t5jcis6a65ku Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlh4wjMACgkQJNaLcl1U h9CaQgf/SC38suTWLXipwit5LvAwHerMkSzKX7bq3rQMiQpiqxv6CdmEl09SoAUX wf5Frbd82cb8WGTlALczkiI+oojeY6rS/TANcFSgmiUJ+XBbiH4y4FLTh35HtY7K ZdZ/T/WA+RfgnkH9avZtmBPapGOUgEIS5yL6dhvELA25DmC7Gq7vHTiaELb6DU1K /i6z6Nuf9VXDcm7QzH7/oZewn5s4GqqCH2ejU4OF/FKTYl7izWdCvYMgFT9HBN+a PNUUq9raIVl0yvdzTNXeHe5eRnF1aWpCtZHFOIvWScj63kKa12DYCsi6V2fgOZ9X 488Z3J4RBQ9WEcHR7Q9eefOwNpO4dw== =/+jI -----END PGP SIGNATURE----- --atb5t5jcis6a65ku--