From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751880AbdAMMky (ORCPT ); Fri, 13 Jan 2017 07:40:54 -0500 Received: from server.atrad.com.au ([150.101.241.2]:36156 "EHLO server.atrad.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751612AbdAMMkL (ORCPT ); Fri, 13 Jan 2017 07:40:11 -0500 Date: Fri, 13 Jan 2017 23:08:47 +1030 From: Jonathan Woithe To: Micha?? K??pie?? Cc: Darren Hart , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] platform/x86: fujitsu-laptop: break up complex loop condition Message-ID: <20170113123847.GE9036@marvin.atrad.com.au> References: <20170111085933.2486-1-kernel@kempniu.pl> <20170111085933.2486-4-kernel@kempniu.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170111085933.2486-4-kernel@kempniu.pl> User-Agent: Mutt/1.5.23 (2014-03-12) X-MIMEDefang-action: accept Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 11, 2017 at 09:59:32AM +0100, Micha?? K??pie?? wrote: > The loop condition in acpi_fujitsu_hotkey_release() includes an > assignment, a four-argument function call and a comparison, making it > hard to read. Separate the assignment from the comparison to improve > readability. > > Signed-off-by: Micha?? K??pie?? Acked-by: Jonathan Woithe > --- > drivers/platform/x86/fujitsu-laptop.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c > index e57d3724d2ce..06653a8594ed 100644 > --- a/drivers/platform/x86/fujitsu-laptop.c > +++ b/drivers/platform/x86/fujitsu-laptop.c > @@ -1054,11 +1054,13 @@ static void acpi_fujitsu_hotkey_release(void) > struct input_dev *input = fujitsu_hotkey->input; > int keycode, status; > > - while ((status = kfifo_out_locked(&fujitsu_hotkey->fifo, > + while (true) { > + status = kfifo_out_locked(&fujitsu_hotkey->fifo, > (unsigned char *)&keycode, > sizeof(keycode), > - &fujitsu_hotkey->fifo_lock)) > - == sizeof(keycode)) { > + &fujitsu_hotkey->fifo_lock); > + if (status != sizeof(keycode)) > + return; > input_report_key(input, keycode, 0); > input_sync(input); > vdbg_printk(FUJLAPTOP_DBG_TRACE, > -- > 2.11.0 --