From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751913AbdAMPAO (ORCPT ); Fri, 13 Jan 2017 10:00:14 -0500 Received: from mail-io0-f170.google.com ([209.85.223.170]:35088 "EHLO mail-io0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751739AbdAMPAM (ORCPT ); Fri, 13 Jan 2017 10:00:12 -0500 From: Jens Axboe X-Google-Original-From: Jens Axboe Date: Fri, 13 Jan 2017 08:00:09 -0700 To: Christoph Hellwig Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, osandov@osandov.com, bart.vanassche@sandisk.com Subject: Re: [PATCH 01/10] block: move existing elevator ops to union Message-ID: <20170113150009.GA23338@kernel.dk> References: <1484170803-9311-1-git-send-email-axboe@fb.com> <1484170803-9311-2-git-send-email-axboe@fb.com> <20170113083420.GB16676@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170113083420.GB16676@infradead.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 13 2017, Christoph Hellwig wrote: > On Wed, Jan 11, 2017 at 02:39:54PM -0700, Jens Axboe wrote: > > Prep patch for adding MQ ops as well, since doing anon unions with > > named initializers doesn't work on older compilers. > > My gut feeling tells me MQ schedulers shouldn't share elevator_type. > I'll play around a bit with the code later to see if my gut was right. It's crazy to re-invent a new framework just for MQ schedulers, imho. So you're going to have to come up with something better than a gut feeling. -- Jens Axboe