From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752233AbdAMPVt (ORCPT ); Fri, 13 Jan 2017 10:21:49 -0500 Received: from mx2.suse.de ([195.135.220.15]:51289 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751798AbdAMPVo (ORCPT ); Fri, 13 Jan 2017 10:21:44 -0500 Date: Fri, 13 Jan 2017 16:21:38 +0100 From: Johannes Thumshirn To: "Martin K . Petersen" Cc: Linux SCSI Mailinglist , Linux Kernel Mailinglist , Dick Kennedy Subject: Re: [PATCH] Set elsiocb contexts to NULL after freeing it Message-ID: <20170113152138.GC3409@linux-x5ow.site> References: <20170110110554.13770-1-jthumshirn@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170110110554.13770-1-jthumshirn@suse.de> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [+Cc James S. I'm sorry] On Tue, Jan 10, 2017 at 12:05:54PM +0100, Johannes Thumshirn wrote: > Set the elsiocb contexts to NULL after freeing as others depend on it. > > Signed-off-by: Johannes Thumshirn > --- > drivers/scsi/lpfc/lpfc_els.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c > index 236e4e5..7b6bd8e 100644 > --- a/drivers/scsi/lpfc/lpfc_els.c > +++ b/drivers/scsi/lpfc/lpfc_els.c > @@ -3590,12 +3590,14 @@ lpfc_els_free_iocb(struct lpfc_hba *phba, struct lpfc_iocbq *elsiocb) > } else { > buf_ptr1 = (struct lpfc_dmabuf *) elsiocb->context2; > lpfc_els_free_data(phba, buf_ptr1); > + elsiocb->context2 = NULL; > } > } > > if (elsiocb->context3) { > buf_ptr = (struct lpfc_dmabuf *) elsiocb->context3; > lpfc_els_free_bpl(phba, buf_ptr); > + elsiocb->context3 = NULL; > } > lpfc_sli_release_iocbq(phba, elsiocb); > return 0; Dick, James, any comments? I'd really like to get this in soon as it solves customer issues. Byte, Johannes -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850