From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751738AbdANRAh (ORCPT ); Sat, 14 Jan 2017 12:00:37 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:48602 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751461AbdANRAf (ORCPT ); Sat, 14 Jan 2017 12:00:35 -0500 Date: Sat, 14 Jan 2017 12:00:27 -0500 (EST) Message-Id: <20170114.120027.401686898931069481.davem@davemloft.net> To: mayhs11saini@gmail.com Cc: hariprasad@chelsio.com, tklauser@distanz.ch, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] cxgb4: Remove redundant memset before memcpy From: David Miller In-Reply-To: <1484356660-19082-1-git-send-email-mayhs11saini@gmail.com> References: <1484356660-19082-1-git-send-email-mayhs11saini@gmail.com> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 14 Jan 2017 08:01:27 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Shyam Saini Date: Sat, 14 Jan 2017 06:47:40 +0530 > The region set by the call to memset, immediately overwritten by > the subsequent call to memcpy and thus makes the memset redundant. > > Also remove the memset((&info, 0, sizeof(info)) on line 398 because > info is memcpy()'ed to before being used in the loop and it isn't > used outside of the loop. > > Signed-off-by: Shyam Saini Applied to net-next, thanks.