From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750899AbdANAzg (ORCPT ); Fri, 13 Jan 2017 19:55:36 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:34744 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750812AbdANAzf (ORCPT ); Fri, 13 Jan 2017 19:55:35 -0500 Date: Sat, 14 Jan 2017 06:25:22 +0530 From: Shyam Saini To: Tobias Klauser Cc: hariprasad@chelsio.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] cxgb4: Remove redundant memset before memcpy Message-ID: <20170114005522.GA16952@mystictot> References: <1484301169-11724-1-git-send-email-mayhs11saini@gmail.com> <20170113155714.GE1201@distanz.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170113155714.GE1201@distanz.ch> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 13, 2017 at 04:57:14PM +0100, Tobias Klauser wrote: > On 2017-01-13 at 10:52:49 +0100, Shyam Saini wrote: > > The region set by the call to memset, immediately overwritten by the > > subsequent call to memcpy and thus makes the memset redundant > > > > Signed-off-by: Shyam Saini > > --- > > drivers/net/ethernet/chelsio/cxgb4/sched.c | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/drivers/net/ethernet/chelsio/cxgb4/sched.c b/drivers/net/ethernet/chelsio/cxgb4/sched.c > > index cbd68a8..5725693 100644 > > --- a/drivers/net/ethernet/chelsio/cxgb4/sched.c > > +++ b/drivers/net/ethernet/chelsio/cxgb4/sched.c > > @@ -398,7 +398,6 @@ static struct sched_class *t4_sched_class_lookup(struct port_info *pi, > > struct ch_sched_params tp; > > > > memset(&info, 0, sizeof(info)); > > This memset is also redundant because info is memcpy()'ed to before > being used in the loop (and it isn't used outside of the loop). Thanks a lot for pointing out that. I'll remove that too and resend it. Regards, Shyam