From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751322AbdANGgk (ORCPT ); Sat, 14 Jan 2017 01:36:40 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:39067 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750901AbdANGgi (ORCPT ); Sat, 14 Jan 2017 01:36:38 -0500 Date: Sat, 14 Jan 2017 09:36:08 +0300 From: Dan Carpenter To: SF Markus Elfring Cc: linux-spi@vger.kernel.org, Mark Brown , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH 14/17] spi/topcliff-pch: Adjust six checks for null pointers Message-ID: <20170114063608.GD15314@mwanda> References: <1413e173-dbac-7a6e-09cb-2287300a335e@users.sourceforge.net> <676a6351-ec06-9744-9f6f-753feb65f8fb@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <676a6351-ec06-9744-9f6f-753feb65f8fb@users.sourceforge.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 13, 2017 at 06:24:22PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 13 Jan 2017 16:16:05 +0100 > MIME-Version: 1.0 > Content-Type: text/plain; charset=UTF-8 > Content-Transfer-Encoding: 8bit > > The script "checkpatch.pl" pointed information out like the following. > > Comparison to NULL could be written … > > Thus fix the affected source code places. > > Signed-off-by: Markus Elfring > --- > drivers/spi/spi-topcliff-pch.c | 15 ++++++--------- > 1 file changed, 6 insertions(+), 9 deletions(-) > > diff --git a/drivers/spi/spi-topcliff-pch.c b/drivers/spi/spi-topcliff-pch.c > index 0a876311b67b..e4f1f66b751b 100644 > --- a/drivers/spi/spi-topcliff-pch.c > +++ b/drivers/spi/spi-topcliff-pch.c > @@ -531,12 +531,11 @@ static int pch_spi_transfer(struct spi_device *pspi, struct spi_message *pmsg) > static inline void pch_spi_select_chip(struct pch_spi_data *data, > struct spi_device *pspi) > { > - if (data->current_chip != NULL) { > + if (data->current_chip) Put the curly braces back. Multi-line indents get curly braces for readability. > if (pspi->chip_select != data->n_curnt_chip) { > dev_dbg(&pspi->dev, "%s : different slave\n", __func__); > data->current_chip = NULL; > } > - } regards, dan carpenter