From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: David Lechner <david@lechnology.com>
Cc: linux-input@vger.kernel.org, devicetree@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] Input: pwm-beeper: suppress error message on probe defer
Date: Sat, 14 Jan 2017 11:17:12 -0800 [thread overview]
Message-ID: <20170114191712.GB31309@dtor-ws> (raw)
In-Reply-To: <1484164921-30587-2-git-send-email-david@lechnology.com>
On Wed, Jan 11, 2017 at 02:01:59PM -0600, David Lechner wrote:
> This suppress printing an error message when pwm_get returns -EPROBE_DEFER.
> Otherwise you get a bunch of noise in the kernel log.
>
> Signed-off-by: David Lechner <david@lechnology.com>
> ---
> drivers/input/misc/pwm-beeper.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/input/misc/pwm-beeper.c b/drivers/input/misc/pwm-beeper.c
> index ce6eec4..30ac227 100644
> --- a/drivers/input/misc/pwm-beeper.c
> +++ b/drivers/input/misc/pwm-beeper.c
> @@ -104,9 +104,10 @@ static int pwm_beeper_probe(struct platform_device *pdev)
> return -ENOMEM;
>
> beeper->pwm = devm_pwm_get(dev, NULL);
> - if (IS_ERR(beeper->pwm)) {
> - error = PTR_ERR(beeper->pwm);
> - dev_err(dev, "Failed to request pwm device: %d\n", error);
> + error = PTR_ERR_OR_ZERO(beeper->pwm);
> + if (error) {
I do not find it in any way clearer than
if (IS_ERR()) {
...
I prefer PTR_ERR_OR_ZERO be used when you need to return value without
acting on it.
I can adjust locally, no need to resubmit.
> + if (error != -EPROBE_DEFER)
> + dev_err(dev, "Failed to request pwm device\n");
> return error;
> }
>
> --
> 2.7.4
>
--
Dmitry
next prev parent reply other threads:[~2017-01-14 19:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-11 20:01 [PATCH v2 0/3] Input: add optional amplifier regulator to pwm-beeper (previously "Input: add optional enable gpio to pwm-beeper") David Lechner
2017-01-11 20:01 ` [PATCH v2 1/3] Input: pwm-beeper: suppress error message on probe defer David Lechner
2017-01-14 19:17 ` Dmitry Torokhov [this message]
2017-01-11 20:02 ` [PATCH v2 2/3] dt-bindings: Input: Add optional amp-supply property to pwm-beeper David Lechner
2017-01-18 19:58 ` Rob Herring
2017-01-11 20:02 ` [PATCH v2 3/3] Input: pwm-beeper: add optional amplifier regulator David Lechner
2017-01-14 19:19 ` Dmitry Torokhov
2017-01-16 0:12 ` David Lechner
2017-01-16 0:34 ` Dmitry Torokhov
2017-01-16 1:04 ` David Lechner
2017-01-19 22:34 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170114191712.GB31309@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=david@lechnology.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).